Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ORC-1507: Use Zulu JDK distribution and switch from 21-ea to 21 #1620

Closed
wants to merge 1 commit into from

Conversation

dongjoon-hyun
Copy link
Member

@dongjoon-hyun dongjoon-hyun commented Sep 20, 2023

What changes were proposed in this pull request?

This PR aims to use Zulu JDK distribution instead of Eclipse Temurin because Java 21 is not ready in Temurin yet.

Why are the changes needed?

To have Java 21 test coverage.

Screenshot 2023-09-20 at 9 40 28 AM

How was this patch tested?

Pass the CIs.

@github-actions github-actions bot added the INFRA label Sep 20, 2023
@dongjoon-hyun dongjoon-hyun added this to the 1.9.2 milestone Sep 20, 2023
@dongjoon-hyun dongjoon-hyun changed the title ORC-1507: Use Zulu JDK distribution and switch from 21-ea to 21 ORC-1507: Use Zulu JDK distribution and switch from 21-ea to 21 Sep 20, 2023
Copy link
Contributor

@paliwalashish paliwalashish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@dongjoon-hyun
Copy link
Member Author

Thank you, @mystic-lama . Also, cc @deshanxiao too

dongjoon-hyun added a commit that referenced this pull request Sep 20, 2023
### What changes were proposed in this pull request?

This PR aims to use `Zulu` JDK distribution instead of `Eclipse Temurin` because Java 21 is not ready in `Temurin` yet.

### Why are the changes needed?

To have Java 21 test coverage.

![Screenshot 2023-09-20 at 9 40 28 AM](https://github.com/apache/orc/assets/9700541/0dbb38ba-34a7-4180-9608-e577bb3023e2)

### How was this patch tested?

Pass the CIs.

Closes #1620 from dongjoon-hyun/ORC-1507.

Authored-by: Dongjoon Hyun <[email protected]>
Signed-off-by: Dongjoon Hyun <[email protected]>
(cherry picked from commit d005449)
Signed-off-by: Dongjoon Hyun <[email protected]>
@deshanxiao
Copy link
Contributor

Late +1 Thank you @dongjoon-hyun

@dongjoon-hyun dongjoon-hyun deleted the ORC-1507 branch September 21, 2023 15:40
cxzl25 pushed a commit to cxzl25/orc that referenced this pull request Jan 11, 2024
### What changes were proposed in this pull request?

This PR aims to use `Zulu` JDK distribution instead of `Eclipse Temurin` because Java 21 is not ready in `Temurin` yet.

### Why are the changes needed?

To have Java 21 test coverage.

![Screenshot 2023-09-20 at 9 40 28 AM](https://github.com/apache/orc/assets/9700541/0dbb38ba-34a7-4180-9608-e577bb3023e2)

### How was this patch tested?

Pass the CIs.

Closes apache#1620 from dongjoon-hyun/ORC-1507.

Authored-by: Dongjoon Hyun <[email protected]>
Signed-off-by: Dongjoon Hyun <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants