ORC-1021: Add -fno-omit-frame-pointer in DEBUG and RELWITHDEBINFO builds #932
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
+1 LGTM |
dongjoon-hyun
approved these changes
Oct 9, 2021
There was a problem hiding this comment.
+1, LGTM. Thank you so much, @stiga-huang and @guiyanakuang .
Merged to main for Apache ORC 1.8.
|
I backported this to branch-1.7. |
dongjoon-hyun
pushed a commit
that referenced
this pull request
Dec 16, 2021
…lds (#932) ### What changes were proposed in this pull request? This PR adds -fno-omit-frame-pointer gcc option in DEBUG and RELWITHDEBINFO builds, which helps to generate stacktrace in debugging and profiling. Refs: https://www.brendangregg.com/perf.html#StackTraces https://issues.apache.org/jira/browse/IMPALA-4132 ### Why are the changes needed? Described as above. ### How was this patch tested? Built in ubuntu16.04 with gcc 8.4.0. (cherry picked from commit 4b9c45c) Signed-off-by: Dongjoon Hyun <[email protected]>
stiga-huang
added a commit
to stiga-huang/orc
that referenced
this pull request
Jan 19, 2022
…lds (apache#932) ### What changes were proposed in this pull request? This PR adds -fno-omit-frame-pointer gcc option in DEBUG and RELWITHDEBINFO builds, which helps to generate stacktrace in debugging and profiling. Refs: https://www.brendangregg.com/perf.html#StackTraces https://issues.apache.org/jira/browse/IMPALA-4132 ### Why are the changes needed? Described as above. ### How was this patch tested? Built in ubuntu16.04 with gcc 8.4.0.
stiga-huang
added a commit
to stiga-huang/orc
that referenced
this pull request
May 4, 2022
…lds (apache#932) ### What changes were proposed in this pull request? This PR adds -fno-omit-frame-pointer gcc option in DEBUG and RELWITHDEBINFO builds, which helps to generate stacktrace in debugging and profiling. Refs: https://www.brendangregg.com/perf.html#StackTraces https://issues.apache.org/jira/browse/IMPALA-4132 ### Why are the changes needed? Described as above. ### How was this patch tested? Built in ubuntu16.04 with gcc 8.4.0.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR adds -fno-omit-frame-pointer gcc option in DEBUG and RELWITHDEBINFO builds, which helps to generate stacktrace in debugging and profiling. Refs:
https://www.brendangregg.com/perf.html#StackTraces
https://issues.apache.org/jira/browse/IMPALA-4132
Why are the changes needed?
Described as above.
How was this patch tested?
Built in ubuntu16.04 with gcc 8.4.0.