ORC-1023: Support writing bloom filters in ConvertTool #933
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It would feel better to update the doc together. https://github.com/apache/orc/blob/main/site/_docs/java-tools.md 😄 |
There was a problem hiding this comment.
Thank you for making a PR, @stiga-huang .
+1 for @guiyanakuang 's review comment.
|
Nice catch! Updated the doc. |
dongjoon-hyun
approved these changes
Oct 11, 2021
|
Hi, @stiga-huang and @guiyanakuang . |
dongjoon-hyun
pushed a commit
that referenced
this pull request
Dec 16, 2021
### What changes were proposed in this pull request? This PR adds an option to the java tool ConvertTool to specify which columns it should generate bloom filters. ### Why are the changes needed? While debugging an issue, I need to generate an ORC file with bloom filters using the Java APIs. The ConvertTool is easy to use but it doesn't generate bloom filters. It'd be helpful to add an option for it. ### How was this patch tested? Didn't find any existing tests on ConvertTool. So I manually tested it and verified the bloom filters are generated. (cherry picked from commit 7c45137) Signed-off-by: Dongjoon Hyun <[email protected]>
|
This is backported to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR adds an option to the java tool ConvertTool to specify which columns it should generate bloom filters.
Why are the changes needed?
While debugging an issue, I need to generate an ORC file with bloom filters using the Java APIs. The ConvertTool is easy to use but it doesn't generate bloom filters. It'd be helpful to add an option for it.
How was this patch tested?
Didn't find any existing tests on ConvertTool. So I manually tested it and verified the bloom filters are generated.