-
Notifications
You must be signed in to change notification settings - Fork 499
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HDDS-10761. Add raft close threshold config to OM RaftProperties #6594
Conversation
@szetszwo @adoroszlai Hi, could you help to review if you have time ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@whbing , thanks a lot for working on this!
- Let's don't have the formatting/whitespace changes here. It is hard to review. We may do it separately.
- Let's don't get the same conf twice. It makes it hard to see the relation of the ratis/ozone confs.
Please see also the comments inlined and also https://issues.apache.org/jira/secure/attachment/13068497/6594_review.patch
...ne/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/ratis/OzoneManagerRatisServer.java
Show resolved
Hide resolved
...ne/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/ratis/OzoneManagerRatisServer.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 the change looks good.
@whbing , thanks for doing that.! How about submitting another pull request for the formatting changes? |
@szetszwo Thanks for review and merge ! |
What changes were proposed in this pull request?
OM crash as the following logs:
This pr makes the close-threshold value configurable from the OM side.
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-10761
How was this patch tested?
manual tests: debug ratis and trace the value.