HDDS-10802. Improve logging for signature verification #6630
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@fapifta, @ChenSammi could you please take a look, thanks! |
adoroszlai
reviewed
May 5, 2024
...anager/src/main/java/org/apache/hadoop/ozone/security/OzoneDelegationTokenSecretManager.java
Outdated
Show resolved
Hide resolved
...anager/src/main/java/org/apache/hadoop/ozone/security/OzoneDelegationTokenSecretManager.java
Outdated
Show resolved
Hide resolved
…ne/security/OzoneDelegationTokenSecretManager.java Co-authored-by: Doroszlai, Attila <[email protected]>
…ne/security/OzoneDelegationTokenSecretManager.java Co-authored-by: Doroszlai, Attila <[email protected]>
|
Thanks @tanvipenumudy for the patch, @ayushtkn for the review. |
jojochuang
pushed a commit
to jojochuang/ozone
that referenced
this pull request
May 29, 2024
(cherry picked from commit 1cbee60)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
When one encounters a 'Tampered/Invalid token' exception, it may occur due to
OzoneDelegationTokenSecretManager#verifySignature failing in any one of the following scenarios:
Related code snippet link.
While we are already logging an error for the latter two cases, this patch introduces additional logging for the former two cases.
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-10802
How was this patch tested?
Trivial logging change.