HDDS-11375. DN startup fails due to illegal configuration of raft.grpc.message.size.max #7128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change-Id: I355dd25654864c1e917d3c13e0fb99b263d26de5 (cherry picked from commit 0127097cadc3ac318b56e548b6d59f68626faaef)
Change-Id: Ic9be1662a348c9c65c4df1140a5fb3aa353b3e50
This reverts commit d8f7fdd.
…x to 33MB." This reverts commit c03d53c.
…ult hdds.container.ratis.log.appender.queue.byte-limit in the integration test to 32MB Change-Id: I76481ea60a0bd37e5f72007b882f741e9a1a82c6
ashishkumar50
approved these changes
Aug 28, 2024
adoroszlai
changed the title
smengcl
approved these changes
Aug 28, 2024
xichen01
pushed a commit
to xichen01/ozone
that referenced
this pull request
Sep 16, 2024
…c.message.size.max (apache#7128) (cherry picked from commit 5659b7e)
xichen01
pushed a commit
to xichen01/ozone
that referenced
this pull request
Sep 18, 2024
…c.message.size.max (apache#7128) (cherry picked from commit 5659b7e)
xichen01
pushed a commit
to xichen01/ozone
that referenced
this pull request
Sep 28, 2024
…c.message.size.max (apache#7128) (cherry picked from commit 5659b7e)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
HDDS-11375. DN Startup fails with "RuntimeException: Can't start the HDDS datanode plugin"
Please describe your PR in detail:
Note: HDDS-11320 did update hdds.ratis.raft.grpc.message.size to be hdds.container.ratis.log.appender.queue.byte-limit + 1MB, but later it got override here: https://github.com/apache/ozone/blob/master/hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/common/transport/server/ratis/XceiverServerRatis.java#L370
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-11375
How was this patch tested?
https://github.com/jojochuang/ozone/actions/runs/10588626984
without removing hdds.ratis.raft.grpc.message.size, TestMiniOzoneCluster using Ratis master branch fails with the exact same error.
https://github.com/jojochuang/ozone/actions/runs/10589356146
Running TestMiniOzoneCluster using the fix and Ratis master branch does not fail.