Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HDDS-11545. [UI] Add OM and SCM ID information #7287

Merged
merged 2 commits into from
Oct 16, 2024
Merged

HDDS-11545. [UI] Add OM and SCM ID information #7287

merged 2 commits into from
Oct 16, 2024

Conversation

devabhishekpal
Copy link
Contributor

@devabhishekpal devabhishekpal commented Oct 8, 2024 •
edited by ArafatKhan2198
Loading

What changes were proposed in this pull request?

HDDS-11545. Added OM ID and SCM ID information

Please describe your PR in detail:

  • We had a card displaying the OM Id and SCM id in the old UI however the new UI doesn't have this
  • As a part of this PR we add a small metadata to the Overview page to display the IDs
  • This is helpful in case of running commands or debugging where we can directly get the ID from Recon UI

What is the link to the Apache JIRA

https://issues.apache.org/jira/browse/HDDS-11545

How was this patch tested?

Patch was tested manually.
image

@adoroszlai adoroszlai added the UI label Oct 8, 2024
@ivandika3 ivandika3 added the recon label Oct 9, 2024
ArafatKhan2198
ArafatKhan2198 approved these changes Oct 16, 2024
View reviewed changes
Copy link
Contributor

@ArafatKhan2198 ArafatKhan2198 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the improvement @devabhishekpal
LGTM +1

dombizita
dombizita approved these changes Oct 16, 2024
View reviewed changes
Copy link
Contributor

@dombizita dombizita left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this @devabhishekpal!

@dombizita dombizita changed the title HDDS-11545. Added OM ID and SCM ID information HDDS-11545. [UI] Add OM and SCM ID information Oct 16, 2024
@ArafatKhan2198
Copy link
Contributor

Thanks for the patch @devabhishekpal
Thanks for the review @dombizita

@dombizita dombizita merged commit 4b24aa9 into apache:master Oct 16, 2024
35 checks passed
@devabhishekpal devabhishekpal deleted the HDDS-11545 branch October 16, 2024 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dombizita dombizita dombizita approved these changes

@ArafatKhan2198 ArafatKhan2198 ArafatKhan2198 approved these changes

@devmadhuu devmadhuu Awaiting requested review from devmadhuu

Assignees
No one assigned
Labels
recon UI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@devabhishekpal @ArafatKhan2198 @dombizita @adoroszlai @ivandika3