GH-2956: Use avro SchemaBuilder API to convert record #2957
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The avro schema builder API is cleaned and more stable. It decreases chance of using newly introduced avro API in case user run with legacy avro version As OPTIONAL converted fields sets null as default, increas consistency by usin [] as default for REPEATED converted fields.
Fokko
approved these changes
Jul 16, 2024
There was a problem hiding this comment.
Looks good @RustedBones Thanks for working on this
Can you run mvn spotless:apply?
wgtmac
approved these changes
Jul 22, 2024
Fokko
pushed a commit
that referenced
this pull request
Aug 14, 2024
The avro schema builder API is cleaned and more stable. It decreases chance of using newly introduced avro API in case user run with legacy avro version As OPTIONAL converted fields sets null as default, increase consistency by using [] as default for REPEATED converted fields.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The avro schema builder API is cleaner and more stable. It decreases chance of using newly introduced avro API in case user run with legacy avro version
As OPTIONAL converted fields sets null as default, increase consistency by using [] as default for REPEATED converted fields.
Fix: #2956