Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GH-1701: fix double close of ParquetFileWriter #2958

Closed
wants to merge 1 commit into from
Closed

GH-1701: fix double close of ParquetFileWriter #2958

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions parquet-hadoop/src/main/java/org/apache/parquet/hadoop/ParquetFileWriter.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -175,6 +175,9 @@ public static enum Mode {
private final ReusingByteBufferAllocator crcAllocator;
private final boolean pageWriteChecksumEnabled;

// set when PositionOutputStream is closed
private boolean closed;

/**
* Captures the order in which methods should be called
*/
Expand Down Expand Up @@ -1658,11 +1661,17 @@ public void end(Map<String, String> extraMetaData) throws IOException {

@Override
public void close() throws IOException {
if (closed) {
return;
}

try (PositionOutputStream temp = out) {
temp.flush();
if (crcAllocator != null) {
crcAllocator.close();
}
} finally {
closed = true;
}
}

Expand Down