reproducible builds #71
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nvollmar
reviewed
Jul 25, 2023
|
Thanks @nvollmar. I need to get back to this at some stage but something about this change is causing unit test failures and that will need to be investigated. |
|
@raboof Pinging you because the |
|
The tests that fail rely on finding cassandra-bundle.jar, one of the jars produced during the build. Something about enabling sbt-reproducible-builds upsets this lookup. |
Update build.sbt
|
hmm, I wonder if updating https://github.com/raboof/sbt-reproducible-builds/blob/main/build.sbt#L39 would help - though it seems unlikely, being a 'provided' dependency |
raboof
added a commit
to raboof/pekko-persistence-cassandra
that referenced
this pull request
Jun 7, 2024
Another go at apache#71/apache#80, might work now that apache#193 was fixed
raboof
added a commit
to raboof/pekko-persistence-cassandra
that referenced
this pull request
Jun 7, 2024
Another go at apache#71/apache#80, might work now that apache#193 was fixed
raboof
added a commit
that referenced
this pull request
Jun 8, 2024
* add sbt-reproducible-builds Another go at #71/#80, might work now that #193 was fixed * fix: cassandraLauncher build with ReproducibleBuildsPlugin * chore: use unmanagedResources * chore: remove target depend --------- Co-authored-by: Arnout Engelen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.