Add missing java api for StreamTestKit #1186
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
He-Pin
force-pushed
the
streamKit
branch
2 times, most recently
from
812f1ea
to
650ef9d
Compare
pjfanning
reviewed
Mar 19, 2024
| @@ -136,15 +136,15 @@ class StreamTestKitSpec extends PekkoSpec { | |||
| // It also needs to be dilated since the testkit will dilate the timeout | |||
| // accordingly to `-Dpekko.test.timefactor` value. | |||
| val initialDelay = (timeout * 2).dilated | |||
| val pf: PartialFunction[Any, Unit] = { | |||
There was a problem hiding this comment.
these changes seem quite small compared to the StreamTestKit changes
is it possible to test all the new functions?
There was a problem hiding this comment.
Sorry, I'm a little busy at $Work right now, testing all these new methods seems like a lot of work, and as we can see, the changes are mostly small, just forwarding/converting.
He-Pin
commented
Mar 20, 2024
| @@ -1242,8 +1242,7 @@ public void mustBeAbleToUseMerge3() { | |||
| .mergeAll(Arrays.asList(sourceB, sourceC), false) | |||
| .runWith(TestSink.probe(system), system); | |||
| sub.expectSubscription().request(9); | |||
| sub.expectNextUnorderedN(Util.immutableSeq(Arrays.asList(1, 2, 3, 4, 5, 6, 7, 8, 9))) | |||
| .expectComplete(); | |||
| sub.expectNextUnorderedN(Arrays.asList(1, 2, 3, 4, 5, 6, 7, 8, 9)).expectComplete(); | |||
There was a problem hiding this comment.
Then, no Util.immutableSeq is needed
mdedetrich
approved these changes
Mar 20, 2024
|
@pjfanning @Roiocam WDYT, should it be included in m1 release？ |
|
Lgtm |
|
Thanks |
pjfanning
added
the
late-release-note
pjfanning
removed
the
late-release-note
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
Add more java native api to StreamTestKit.
refs:#970
was: #1049
continue the work of @naosense