Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Fix expectNextWithTimeoutPF #1218

Merged
merged 1 commit into from
Mar 23, 2024

Conversation

He-Pin
Copy link
Member

@He-Pin He-Pin commented Mar 23, 2024

Motivaition:
Fix #1217

@He-Pin He-Pin added the t:stream Pekko Streams label Mar 23, 2024
@He-Pin He-Pin added this to the 1.1.0-M1 milestone Mar 23, 2024
@He-Pin He-Pin requested a review from pjfanning March 23, 2024 10:56
}
expectEventWithTimeoutPF(max, pf.andThen(f))
expectEventWithTimeoutPF[T](max, pf)
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was only supported on Scala 2.13 :(

Copy link
Contributor

@pjfanning pjfanning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@He-Pin He-Pin merged commit 33a845a into apache:main Mar 23, 2024
18 checks passed
@He-Pin He-Pin deleted the expectNextWithTimeoutPF branch March 23, 2024 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
t:stream Pekko Streams
Projects
None yet
Development

Successfully merging this pull request may close these issues.

stream-testkit tests fail with Scala 2.12 - release blocker
3 participants