Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update scala3-library to 3.3.4 #1506

Merged
merged 2 commits into from
Oct 7, 2024
Merged

Update scala3-library to 3.3.4 #1506

merged 2 commits into from
Oct 7, 2024

Conversation

scala-steward-asf[bot]
Copy link
Contributor

About this PR

πŸ“¦ Updates org.scala-lang:scala3-library from 3.3.3 to 3.3.4

πŸ“œ GitHub Release Notes - Version Diff - Version Diff

Usage

βœ… Please merge!

I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.

If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.

Configure Scala Steward for your repository with a .scala-steward.conf file.

Have a fantastic day writing Scala!

βš™ Adjust future updates

Add this to your .scala-steward.conf file to ignore future updates of this dependency:

updates.ignore = [ { groupId = "org.scala-lang", artifactId = "scala3-library" } ]

Or, add this to slow down future updates of this dependency:

dependencyOverrides = [{
  pullRequests = { frequency = "30 days" },
  dependency = { groupId = "org.scala-lang", artifactId = "scala3-library" }
}]
labels: library-update, early-semver-patch, semver-spec-patch, version-scheme:semver-spec, commit-count:1

Copy link
Contributor

@pjfanning pjfanning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need to discuss mima issues in #1474

@pjfanning
Copy link
Contributor

Breaks some tests that check logging

2024-10-03T00:08:58.4024268Z [10-03 00:08:58.399] οΏ½[0m[οΏ½[0mοΏ½[0minfoοΏ½[0m] οΏ½[0mοΏ½[0mοΏ½[31m- must always log user message in context.log *** FAILED *** (6 seconds, 15 milliseconds)οΏ½[0mοΏ½[0m
2024-10-03T00:08:58.4028706Z [10-03 00:08:58.400] οΏ½[0m[οΏ½[0mοΏ½[0minfoοΏ½[0m] οΏ½[0mοΏ½[0mοΏ½[31m  java.lang.AssertionError: Timeout (6 seconds) waiting for 1 messages on LoggingTestKitImpl(1,Some(INFO),Some(org.apache.pekko.persistence.typed.EventSourcedBehaviorLoggingSpec$ChattyEventSourcingBehavior$),None,Some(received message 'Mary'),None,None,Map(),true,None).οΏ½[0mοΏ½[0m
2024-10-03T00:08:58.4032991Z [10-03 00:08:58.400] οΏ½[0m[οΏ½[0mοΏ½[0minfoοΏ½[0m] οΏ½[0mοΏ½[0mοΏ½[31m  at org.apache.pekko.actor.testkit.typed.internal.LoggingTestKitImpl.expect(LoggingTestKitImpl.scala:113)οΏ½[0mοΏ½[0m
2024-10-03T00:08:58.4036169Z [10-03 00:08:58.400] οΏ½[0m[οΏ½[0mοΏ½[0minfoοΏ½[0m] οΏ½[0mοΏ½[0mοΏ½[31m  at org.apache.pekko.persistence.typed.EventSourcedBehaviorLoggingSpec.f$proxy1$1(EventSourcedBehaviorLoggingSpec.scala:86)οΏ½[0mοΏ½[0m
2024-10-03T00:08:58.4039513Z [10-03 00:08:58.400] οΏ½[0m[οΏ½[0mοΏ½[0minfoοΏ½[0m] οΏ½[0mοΏ½[0mοΏ½[31m  at org.apache.pekko.persistence.typed.EventSourcedBehaviorLoggingSpec.$init$$$anonfun$1$$anonfun$1(EventSourcedBehaviorLoggingSpec.scala:87)οΏ½[0mοΏ½[0m
2024-10-03T00:08:58.4042304Z [10-03 00:08:58.400] οΏ½[0m[οΏ½[0mοΏ½[0minfoοΏ½[0m] οΏ½[0mοΏ½[0mοΏ½[31m  at org.scalatest.Transformer.apply$$anonfun$1(Transformer.scala:22)οΏ½[0mοΏ½[0m
2024-10-03T00:08:58.4044345Z [10-03 00:08:58.400] οΏ½[0m[οΏ½[0mοΏ½[0minfoοΏ½[0m] οΏ½[0mοΏ½[0mοΏ½[31m  at org.scalatest.OutcomeOf.outcomeOf(OutcomeOf.scala:85)οΏ½[0mοΏ½[0m
2024-10-03T00:08:58.4046302Z [10-03 00:08:58.400] οΏ½[0m[οΏ½[0mοΏ½[0minfoοΏ½[0m] οΏ½[0mοΏ½[0mοΏ½[31m  at org.scalatest.OutcomeOf.outcomeOf$(OutcomeOf.scala:31)οΏ½[0mοΏ½[0m
2024-10-03T00:08:58.4048265Z [10-03 00:08:58.400] οΏ½[0m[οΏ½[0mοΏ½[0minfoοΏ½[0m] οΏ½[0mοΏ½[0mοΏ½[31m  at org.scalatest.OutcomeOf$.outcomeOf(OutcomeOf.scala:104)οΏ½[0mοΏ½[0m
2024-10-03T00:08:58.4050216Z [10-03 00:08:58.401] οΏ½[0m[οΏ½[0mοΏ½[0minfoοΏ½[0m] οΏ½[0mοΏ½[0mοΏ½[31m  at org.scalatest.Transformer.apply(Transformer.scala:22)οΏ½[0mοΏ½[0m
2024-10-03T00:08:58.4052666Z [10-03 00:08:58.401] οΏ½[0m[οΏ½[0mοΏ½[0minfoοΏ½[0m] οΏ½[0mοΏ½[0mοΏ½[31m  at org.scalatest.Transformer.apply(Transformer.scala:21)οΏ½[0mοΏ½[0m
2024-10-03T00:08:58.4054846Z [10-03 00:08:58.401] οΏ½[0m[οΏ½[0mοΏ½[0minfoοΏ½[0m] οΏ½[0mοΏ½[0mοΏ½[31m  at org.scalatest.wordspec.AnyWordSpecLike$$anon$3.apply(AnyWordSpecLike.scala:1118)οΏ½[0mοΏ½[0m
2024-10-03T00:08:58.4057421Z [10-03 00:08:58.401] οΏ½[0m[οΏ½[0mοΏ½[0minfoοΏ½[0m] οΏ½[0mοΏ½[0mοΏ½[31m  at org.apache.pekko.actor.testkit.typed.scaladsl.LogCapturing.withFixture(LogCapturing.scala:79)οΏ½[0mοΏ½[0m
2024-10-03T00:08:58.4060245Z [10-03 00:08:58.401] οΏ½[0m[οΏ½[0mοΏ½[0minfoοΏ½[0m] οΏ½[0mοΏ½[0mοΏ½[31m  at org.apache.pekko.actor.testkit.typed.scaladsl.LogCapturing.withFixture$(LogCapturing.scala:42)οΏ½[0mοΏ½[0m
2024-10-03T00:08:58.4063305Z [10-03 00:08:58.401] οΏ½[0m[οΏ½[0mοΏ½[0minfoοΏ½[0m] οΏ½[0mοΏ½[0mοΏ½[31m  at org.apache.pekko.persistence.typed.EventSourcedBehaviorLoggingSpec.withFixture(EventSourcedBehaviorLoggingSpec.scala:64)οΏ½[0mοΏ½[0m
2024-10-03T00:08:58.4066225Z [10-03 00:08:58.401] οΏ½[0m[οΏ½[0mοΏ½[0minfoοΏ½[0m] οΏ½[0mοΏ½[0mοΏ½[31m  at org.scalatest.wordspec.AnyWordSpecLike.invokeWithFixture$1(AnyWordSpecLike.scala:1124)οΏ½[0mοΏ½[0m
2024-10-03T00:08:58.4068654Z [10-03 00:08:58.401] οΏ½[0m[οΏ½[0mοΏ½[0minfoοΏ½[0m] οΏ½[0mοΏ½[0mοΏ½[31m  at org.scalatest.wordspec.AnyWordSpecLike.runTest$$anonfun$1(AnyWordSpecLike.scala:1128)οΏ½[0mοΏ½[0m
2024-10-03T00:08:58.4076205Z [10-03 00:08:58.401] οΏ½[0m[οΏ½[0mοΏ½[0minfoοΏ½[0m] οΏ½[0mοΏ½[0mοΏ½[31m  at org.scalatest.SuperEngine.runTestImpl(Engine.scala:306)οΏ½[0mοΏ½[0m
2024-10-03T00:08:58.4078598Z [10-03 00:08:58.401] οΏ½[0m[οΏ½[0mοΏ½[0minfoοΏ½[0m] οΏ½[0mοΏ½[0mοΏ½[31m  at org.scalatest.wordspec.AnyWordSpecLike.runTest(AnyWordSpecLike.scala:1128)οΏ½[0mοΏ½[0m
2024-10-03T00:08:58.4080749Z [10-03 00:08:58.402] οΏ½[0m[οΏ½[0mοΏ½[0minfoοΏ½[0m] οΏ½[0mοΏ½[0mοΏ½[31m  at org.scalatest.wordspec.AnyWordSpecLike.runTest$(AnyWordSpecLike.scala:44)οΏ½[0mοΏ½[0m
2024-10-03T00:08:58.4083716Z [10-03 00:08:58.402] οΏ½[0m[οΏ½[0mοΏ½[0minfoοΏ½[0m] οΏ½[0mοΏ½[0mοΏ½[31m  at org.apache.pekko.persistence.typed.EventSourcedBehaviorLoggingSpec.runTest(EventSourcedBehaviorLoggingSpec.scala:64)οΏ½[0mοΏ½[0m
2024-10-03T00:08:58.4086714Z [10-03 00:08:58.402] οΏ½[0m[οΏ½[0mοΏ½[0minfoοΏ½[0m] οΏ½[0mοΏ½[0mοΏ½[31m  at org.scalatest.wordspec.AnyWordSpecLike.runTests$$anonfun$1(AnyWordSpecLike.scala:1187)οΏ½[0mοΏ½[0m
2024-10-03T00:08:58.4089111Z [10-03 00:08:58.402] οΏ½[0m[οΏ½[0mοΏ½[0minfoοΏ½[0m] οΏ½[0mοΏ½[0mοΏ½[31m  at org.scalatest.SuperEngine.traverseSubNodes$1$$anonfun$1(Engine.scala:413)οΏ½[0mοΏ½[0m
2024-10-03T00:08:58.4091103Z [10-03 00:08:58.402] οΏ½[0m[οΏ½[0mοΏ½[0minfoοΏ½[0m] οΏ½[0mοΏ½[0mοΏ½[31m  at scala.runtime.function.JProcedure1.apply(JProcedure1.java:15)οΏ½[0mοΏ½[0m
2024-10-03T00:08:58.4093345Z [10-03 00:08:58.402] οΏ½[0m[οΏ½[0mοΏ½[0minfoοΏ½[0m] οΏ½[0mοΏ½[0mοΏ½[31m  at scala.runtime.function.JProcedure1.apply(JProcedure1.java:10)οΏ½[0mοΏ½[0m
2024-10-03T00:08:58.4095462Z [10-03 00:08:58.402] οΏ½[0m[οΏ½[0mοΏ½[0minfoοΏ½[0m] οΏ½[0mοΏ½[0mοΏ½[31m  at scala.collection.immutable.List.foreach(List.scala:334)οΏ½[0mοΏ½[0m
2024-10-03T00:08:58.4097299Z [10-03 00:08:58.402] οΏ½[0m[οΏ½[0mοΏ½[0minfoοΏ½[0m] οΏ½[0mοΏ½[0mοΏ½[31m  at org.scalatest.SuperEngine.traverseSubNodes$1(Engine.scala:429)οΏ½[0mοΏ½[0m
2024-10-03T00:08:58.4099319Z [10-03 00:08:58.403] οΏ½[0m[οΏ½[0mοΏ½[0minfoοΏ½[0m] οΏ½[0mοΏ½[0mοΏ½[31m  at org.scalatest.SuperEngine.runTestsInBranch(Engine.scala:390)οΏ½[0mοΏ½[0m
2024-10-03T00:08:58.4101404Z [10-03 00:08:58.403] οΏ½[0m[οΏ½[0mοΏ½[0minfoοΏ½[0m] οΏ½[0mοΏ½[0mοΏ½[31m  at org.scalatest.SuperEngine.traverseSubNodes$1$$anonfun$1(Engine.scala:427)οΏ½[0mοΏ½[0m
2024-10-03T00:08:58.4103385Z [10-03 00:08:58.403] οΏ½[0m[οΏ½[0mοΏ½[0minfoοΏ½[0m] οΏ½[0mοΏ½[0mοΏ½[31m  at scala.runtime.function.JProcedure1.apply(JProcedure1.java:15)οΏ½[0mοΏ½[0m
2024-10-03T00:08:58.4105601Z [10-03 00:08:58.403] οΏ½[0m[οΏ½[0mοΏ½[0minfoοΏ½[0m] οΏ½[0mοΏ½[0mοΏ½[31m  at scala.runtime.function.JProcedure1.apply(JProcedure1.java:10)οΏ½[0mοΏ½[0m
2024-10-03T00:08:58.4107529Z [10-03 00:08:58.403] οΏ½[0m[οΏ½[0mοΏ½[0minfoοΏ½[0m] οΏ½[0mοΏ½[0mοΏ½[31m  at scala.collection.immutable.List.foreach(List.scala:334)οΏ½[0mοΏ½[0m
2024-10-03T00:08:58.4109473Z [10-03 00:08:58.403] οΏ½[0m[οΏ½[0mοΏ½[0minfoοΏ½[0m] οΏ½[0mοΏ½[0mοΏ½[31m  at org.scalatest.SuperEngine.traverseSubNodes$1(Engine.scala:429)οΏ½[0mοΏ½[0m
2024-10-03T00:08:58.4111521Z [10-03 00:08:58.403] οΏ½[0m[οΏ½[0mοΏ½[0minfoοΏ½[0m] οΏ½[0mοΏ½[0mοΏ½[31m  at org.scalatest.SuperEngine.runTestsInBranch(Engine.scala:396)οΏ½[0mοΏ½[0m
2024-10-03T00:08:58.4113478Z [10-03 00:08:58.403] οΏ½[0m[οΏ½[0mοΏ½[0minfoοΏ½[0m] οΏ½[0mοΏ½[0mοΏ½[31m  at org.scalatest.SuperEngine.runTestsImpl(Engine.scala:475)οΏ½[0mοΏ½[0m
2024-10-03T00:08:58.4115562Z [10-03 00:08:58.403] οΏ½[0m[οΏ½[0mοΏ½[0minfoοΏ½[0m] οΏ½[0mοΏ½[0mοΏ½[31m  at org.scalatest.wordspec.AnyWordSpecLike.runTests(AnyWordSpecLike.scala:1187)οΏ½[0mοΏ½[0m
2024-10-03T00:08:58.4117803Z [10-03 00:08:58.403] οΏ½[0m[οΏ½[0mοΏ½[0minfoοΏ½[0m] οΏ½[0mοΏ½[0mοΏ½[31m  at org.scalatest.wordspec.AnyWordSpecLike.runTests$(AnyWordSpecLike.scala:44)οΏ½[0mοΏ½[0m
2024-10-03T00:08:58.4121093Z [10-03 00:08:58.404] οΏ½[0m[οΏ½[0mοΏ½[0minfoοΏ½[0m] οΏ½[0mοΏ½[0mοΏ½[31m  at org.apache.pekko.persistence.typed.EventSourcedBehaviorLoggingSpec.runTests(EventSourcedBehaviorLoggingSpec.scala:64)οΏ½[0mοΏ½[0m
2024-10-03T00:08:58.4123411Z [10-03 00:08:58.404] οΏ½[0m[οΏ½[0mοΏ½[0minfoοΏ½[0m] οΏ½[0mοΏ½[0mοΏ½[31m  at org.scalatest.Suite.run(Suite.scala:1114)οΏ½[0mοΏ½[0m
2024-10-03T00:08:58.4124820Z [10-03 00:08:58.404] οΏ½[0m[οΏ½[0mοΏ½[0minfoοΏ½[0m] οΏ½[0mοΏ½[0mοΏ½[31m  at org.scalatest.Suite.run$(Suite.scala:564)οΏ½[0mοΏ½[0m
2024-10-03T00:08:58.4127261Z [10-03 00:08:58.404] οΏ½[0m[οΏ½[0mοΏ½[0minfoοΏ½[0m] οΏ½[0mοΏ½[0mοΏ½[31m  at org.apache.pekko.actor.testkit.typed.scaladsl.ScalaTestWithActorTestKit.org$scalatest$BeforeAndAfterAll$$super$run(ScalaTestWithActorTestKit.scala:41)οΏ½[0mοΏ½[0m
2024-10-03T00:08:58.4135206Z [10-03 00:08:58.404] οΏ½[0m[οΏ½[0mοΏ½[0minfoοΏ½[0m] οΏ½[0mοΏ½[0mοΏ½[31m  at org.scalatest.BeforeAndAfterAll.liftedTree1$1(BeforeAndAfterAll.scala:213)οΏ½[0mοΏ½[0m
2024-10-03T00:08:58.4137515Z [10-03 00:08:58.404] οΏ½[0m[οΏ½[0mοΏ½[0minfoοΏ½[0m] οΏ½[0mοΏ½[0mοΏ½[31m  at org.scalatest.BeforeAndAfterAll.run(BeforeAndAfterAll.scala:217)οΏ½[0mοΏ½[0m
2024-10-03T00:08:58.4139560Z [10-03 00:08:58.404] οΏ½[0m[οΏ½[0mοΏ½[0minfoοΏ½[0m] οΏ½[0mοΏ½[0mοΏ½[31m  at org.scalatest.BeforeAndAfterAll.run$(BeforeAndAfterAll.scala:135)οΏ½[0mοΏ½[0m
2024-10-03T00:08:58.4141687Z [10-03 00:08:58.404] οΏ½[0m[οΏ½[0mοΏ½[0minfoοΏ½[0m] οΏ½[0mοΏ½[0mοΏ½[31m  at org.apache.pekko.persistence.typed.EventSourcedBehaviorLoggingSpec.org$scalatest$wordspec$AnyWordSpecLike$$super$run(EventSourcedBehaviorLoggingSpec.scala:64)οΏ½[0mοΏ½[0m
2024-10-03T00:08:58.4145846Z [10-03 00:08:58.404] οΏ½[0m[οΏ½[0mοΏ½[0minfoοΏ½[0m] οΏ½[0mοΏ½[0mοΏ½[31m  at org.scalatest.wordspec.AnyWordSpecLike.run$$anonfun$1(AnyWordSpecLike.scala:1232)οΏ½[0mοΏ½[0m
2024-10-03T00:08:58.4147733Z [10-03 00:08:58.405] οΏ½[0m[οΏ½[0mοΏ½[0minfoοΏ½[0m] οΏ½[0mοΏ½[0mοΏ½[31m  at org.scalatest.SuperEngine.runImpl(Engine.scala:535)οΏ½[0mοΏ½[0m
2024-10-03T00:08:58.4149605Z [10-03 00:08:58.405] οΏ½[0m[οΏ½[0mοΏ½[0minfoοΏ½[0m] οΏ½[0mοΏ½[0mοΏ½[31m  at org.scalatest.wordspec.AnyWordSpecLike.run(AnyWordSpecLike.scala:1232)οΏ½[0mοΏ½[0m
2024-10-03T00:08:58.4152148Z [10-03 00:08:58.405] οΏ½[0m[οΏ½[0mοΏ½[0minfoοΏ½[0m] οΏ½[0mοΏ½[0mοΏ½[31m  at org.scalatest.wordspec.AnyWordSpecLike.run$(AnyWordSpecLike.scala:44)οΏ½[0mοΏ½[0m
2024-10-03T00:08:58.4153963Z [10-03 00:08:58.405] οΏ½[0m[οΏ½[0mοΏ½[0minfoοΏ½[0m] οΏ½[0mοΏ½[0mοΏ½[31m  at org.apache.pekko.persistence.typed.EventSourcedBehaviorLoggingSpec.run(EventSourcedBehaviorLoggingSpec.scala:64)οΏ½[0mοΏ½[0m
2024-10-03T00:08:58.4156600Z [10-03 00:08:58.405] οΏ½[0m[οΏ½[0mοΏ½[0minfoοΏ½[0m] οΏ½[0mοΏ½[0mοΏ½[31m  at org.scalatest.tools.Framework.org$scalatest$tools$Framework$$runSuite(Framework.scala:321)οΏ½[0mοΏ½[0m
2024-10-03T00:08:58.4158819Z [10-03 00:08:58.405] οΏ½[0m[οΏ½[0mοΏ½[0minfoοΏ½[0m] οΏ½[0mοΏ½[0mοΏ½[31m  at org.scalatest.tools.Framework$ScalaTestTask.execute(Framework.scala:517)οΏ½[0mοΏ½[0m
2024-10-03T00:08:58.4160733Z [10-03 00:08:58.405] οΏ½[0m[οΏ½[0mοΏ½[0minfoοΏ½[0m] οΏ½[0mοΏ½[0mοΏ½[31m  at sbt.ForkMain$Run.lambda$runTest$1(ForkMain.java:414)οΏ½[0mοΏ½[0m
2024-10-03T00:08:58.4162703Z [10-03 00:08:58.405] οΏ½[0m[οΏ½[0mοΏ½[0minfoοΏ½[0m] οΏ½[0mοΏ½[0mοΏ½[31m  at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264)οΏ½[0mοΏ½[0m
2024-10-03T00:08:58.4165043Z [10-03 00:08:58.406] οΏ½[0m[οΏ½[0mοΏ½[0minfoοΏ½[0m] οΏ½[0mοΏ½[0mοΏ½[31m  at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128)οΏ½[0mοΏ½[0m
2024-10-03T00:08:58.4167619Z [10-03 00:08:58.406] οΏ½[0m[οΏ½[0mοΏ½[0minfoοΏ½[0m] οΏ½[0mοΏ½[0mοΏ½[31m  at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628)οΏ½[0mοΏ½[0m
2024-10-03T00:08:58.4169589Z [10-03 00:08:58.406] οΏ½[0m[οΏ½[0mοΏ½[0minfoοΏ½[0m] οΏ½[0mοΏ½[0mοΏ½[31m  at java.base/java.lang.Thread.run(Thread.java:829)οΏ½[0mοΏ½[0m

@pjfanning pjfanning added this to the 1.1.x milestone Oct 3, 2024
@raboof
Copy link
Member

raboof commented Oct 7, 2024

applied the fix to determine the logging class from the stack trace from #1474 (comment) . I don't think we need to worry about performance here: the added logic should be much faster than the time it already takes to construct the stack trace in the first place.

@pjfanning pjfanning modified the milestones: 1.1.x, 1.1.3 Oct 7, 2024
Copy link
Contributor

@pjfanning pjfanning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@raboof raboof merged commit fd9a0a4 into main Oct 7, 2024
9 checks passed
@pjfanning pjfanning deleted the update/scala3-library-3.3.4 branch October 7, 2024 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants