-
Notifications
You must be signed in to change notification settings - Fork 143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add support for for comprehensions
.
#935
Conversation
3fcceab
to
0903eff
Compare
stream-tests/src/test/scala/org/apache/pekko/stream/scaladsl/ForComprehensionsCompileSpec.scala
Outdated
Show resolved
Hide resolved
stream-tests/src/test/scala/org/apache/pekko/stream/scaladsl/ForComprehensionsCompileSpec.scala
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would still like the new methods marked as experimental. I just think there are chances that we ay need to tweak this support if users try out for
comprehensions and find some oddities.
Maybe not that one - the API signatures won't change but we may need to tweak the internals of the functions. Even we add something like this to the Scaladoc for the new functions.
|
I think the only in question is and for the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm - I would like to see some other reviews though
LGTM for code. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Let me merge this, I think this one should be ready to go, any improvement can come up after. |
Motivation:
refs: #654
Note:
foreach
method just work as fs2, where theStream
needs compile aka pekko'srun
. but different in ZIO, whereforeach
===runForeach
.Result:
for comprehensions
works as fs2 for bothSource
andFlow
in scaladsl