Build and test with multiple versions of Go #269
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, the Pulsar Go Client is only tested against Go version 1.12. The motivation for this change is to help bring confidence that the Go client is compatible with multiple versions of Go, all being tested with each PR. I've modified the two GitHub Action workflows that are a part of this repo with a [matrix](https://help.github.com/en/actions/reference/workflow-syntax-for-github-actions#jobsjob_idstrategymatrix) such that we test against multiple versions of Go. - [X] Make sure that the change passes the CI checks.
merlimat
approved these changes
Jun 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Currently, the Pulsar Go Client is only tested against Go version 1.12. The
motivation for this change is to help bring confidence that the Go client is
compatible with multiple versions of Go, all being tested with each PR.
Modifications
I've modified the two GitHub Action workflows that are a part of this repo with
a matrix such that we test against multiple versions of Go.
I've also modified the current
docker-ci.shscript andDockerfileto allow for injecting a different go version other than the default1.12.Verifying this change