[issue 679][oauth2] Fix macos compiler warnings, remove store impleme…

[llqgit]

…nt keyring which not used at all

Master Issue: #719

Motivation

Fix MacOS version warning from the unused OAuth2 store implement named keyring.go

Modifications

To fix the warning that on MacOS once for all by remove the keyring.go which no references from other places, rather than upgrade the keyring package.

Verifying this change

• Make sure that the change passes the CI checks.

This change is already covered by existing tests, such as (please describe tests).

Does this pull request potentially affect one of the following parts:

• Dependencies (does it add or upgrade a dependency): (yes)
  • removed github.com/99designs/go-keychain

Documentation

• Does this pull request introduce a new feature? (no)

[llqgit]

Any change to confirm PR ?

[shoothzj]

@wolfstudy can you confirm this PR? thanks

[wolfstudy]

cc @zymap Please take a look thanks

[zymap]

It's a persistent implementation, we shouldn't remove it. It's an option of the store implementation, user can choose by themselves.

[llqgit]

@zymap I got it and understand your point.
And I still have a question about it.

If it should be kept for the users which choose this implementation, now what's your opinion about the users not use this extra implementation and still shown the warning below?

It is really annoying when you develop and run the program in every time.

[zymap]

I saw the author has fixed this issue(keybase/go-keychain#76). Could you please try to upgrade the dependency to check if it works?

[llqgit]

@zymap I just run:

go mod init my_project
go mod tidy

This is the official way to init, it should be all right.
And the dependences like this:

If I run my program, the errors shown like this:

You said the new version of github.com/keybase/go-keychain fix the problem.
So, if I just upgrade this package by go get github.com/keybase/go-keychain CMD.

The version would be:

It should be good. But I got some new errors which looks worse:

By the way. My mac OS version

From my perspective, the warning problem was not fixed yet or not effective.

[ciiiii]

@llqgit I think they remove the support to avoid the warning. keybase/go-keychain#76