Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pulsar-manager adding support for existing secret #478

Merged
merged 1 commit into from
Mar 26, 2024

Conversation

doug-ba
Copy link
Contributor

@doug-ba doug-ba commented Mar 22, 2024

Fixes #477

Motivation

The existing solution to automatically generate credentials doesn't work in argocd, it detects a constant difference and changes the credentials repeatedly. The alternative of specifying credentials in values files committed to source control is not good practice.
Allowing users to use an existing secret provisioned by the secrets management solution of their choice solves this problem.

Modifications

Makes the pulsar-manager secret generated by the chart not be created if the value pulsar_manager.admin.existingSecret is specified.
Makes the pulsar-manager initialize job and statefulset utilize an existing secret if it's specified.

Verifying this change

  • Make sure that the change passes the CI checks.

Copy link
Member

@lhotari lhotari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the contribution!

@lhotari lhotari merged commit bc5862d into apache:master Mar 26, 2024
30 checks passed
@robertdumitrescu
Copy link

This does not work. I just tried to specify a secret with the correct keys and is still created its own secret.

pulsar_manager:
  admin:
    existingSecret: local-dev-pulsar-secret-from-es

@doug-ba
Copy link
Contributor Author

doug-ba commented Apr 1, 2024

There isn’t a release that contains this change yet.

@robertdumitrescu
Copy link

When will this be released then? Any timeline?

@lhotari
Copy link
Member

lhotari commented Apr 2, 2024

When will this be released then? Any timeline?

@robertdumitrescu next release in 1-2 weeks

@lhotari
Copy link
Member

lhotari commented Apr 2, 2024

@robertdumitrescu The next release is in voting stage. Please help validate the release: https://lists.apache.org/thread/t4vlvk0nwd3gzo50t466cqy5h95l81gb . The release voting email shows how you can use the release candidate version. Would you be able to test that existing secret works as expected?

@robertdumitrescu
Copy link

Unfortunately, I won't be able to explore this due to other commitments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow specifying an existing secret for pulsar-manager credentials
3 participants