Bugfix/pulsar manager persistence #485
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
only setup environment in pulsar manager if broker is deployed fix indent enable persistence for manager and move configs around
|
I think this solves the previous issues @lhotari @wuyudian1 |
|
Awesome work @Mortom123 ! Thank you |
lhotari
approved these changes
Apr 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #470
Motivation
Reconditioning the pulsar manager after reinstall should not be necessary and data should be persisted.
Modifications
Multiple modifications. It did not work beforehand because
SPRING_CONFIGURATION_FILEwas set in the environment resulting in a default configuration.During my investigations, I found out that the pulsar manager does not setup the database correctly and instead defaults to user/password = pulsar/pulsar.
Once the changes on the side of the manager are implemented the same credentials as specified should be used.
See: apache/pulsar-manager#556
Verifying this change