Fix highlight Quickstart and Concepts menu items at the same time #587
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tisonkun
approved these changes
May 26, 2023
There was a problem hiding this comment.
The result is good, while I'm a bit surprised why the highlight appearance is incorrect with the current config.
I ever saw a similar issue when the button linked to the same page (apache/superset#22486), but this seems not the case.
Currently, I don't have much time to inspect Docusaurus sources to figure out the reason. |
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds doc for #xyz
This PR fixes #xyz
docdoc-requireddoc-not-neededdoc-completeAfter b30efcc, the Concepts, and Quickstart menu items are both highlighted at the same time.
Looks not good. 🙂
This PR fixes it.
Also, this PR fixes the reason behind b30efcc.
The Concepts and Quickstart menu items refer to the latest version now instead of
next.