You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
An additional detail is that it would be better to change the OAuth2 audience claim https://dev-kt-aa9ne.us.auth0.com/api/v2/ in TokenOauth2AuthenticatedProducerConsumerTest during this change since that could cause confusion for future maintainers.
Implementation hints
It's possible to share test classes via pulsar-broker test-jar dependency:
This is already specified in pulsar-proxy/pom.xml and pulsar-testclient/pom.xml
It would be possible to extract some test classes from TokenOauth2AuthenticatedProducerConsumerTest for Wiremocking OAuth and put the classes under some package in pulsar-broker/src/test/java/org/apache/pulsar . This would be a way to reduce code duplication across tests where similar logic is needed.
The text was updated successfully, but these errors were encountered:
Description
Auth0 service dependency in TokenOauth2AuthenticatedProducerConsumerTest was removed in #20465.
It turns out that there is an Auth0 service dependency also in these 2 locations:
pulsar/pulsar-proxy/src/test/java/org/apache/pulsar/proxy/server/ProxyTlsTestWithAuth.java
Lines 67 to 70 in d565c95
pulsar/pulsar-testclient/src/test/java/org/apache/pulsar/testclient/Oauth2PerformanceTransactionTest.java
Lines 87 to 89 in 82237d3
These should also be covered.
An additional detail is that it would be better to change the OAuth2 audience claim
https://dev-kt-aa9ne.us.auth0.com/api/v2/
in TokenOauth2AuthenticatedProducerConsumerTest during this change since that could cause confusion for future maintainers.Implementation hints
It's possible to share test classes via pulsar-broker test-jar dependency:
This is already specified in
pulsar-proxy/pom.xml
andpulsar-testclient/pom.xml
It would be possible to extract some test classes from TokenOauth2AuthenticatedProducerConsumerTest for Wiremocking OAuth and put the classes under some package in pulsar-broker/src/test/java/org/apache/pulsar . This would be a way to reduce code duplication across tests where similar logic is needed.
The text was updated successfully, but these errors were encountered: