[fix][test] Replace test call to Auth0 with call to WireMock #20465
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaeljmarshall
added
area/broker
type/flaky-tests
doc-not-needed
eolivelli
approved these changes
Jun 1, 2023
jiazhai
approved these changes
Jun 2, 2023
tisonkun
approved these changes
Jun 2, 2023
Codecov Report
@@ Coverage Diff @@
## master #20465 +/- ##
============================================
+ Coverage 72.91% 72.93% +0.02%
+ Complexity 31913 3696 -28217
============================================
Files 1867 1867
Lines 138534 138484 -50
Branches 15200 15202 +2
============================================
- Hits 101009 101007 -2
+ Misses 29517 29454 -63
- Partials 8008 8023 +15
Flags with carried forward coverage won't be shown. Click here to find out more.
|
|
Merging... Thank you! |
|
I noticed 2 more locations where Auth0 is used in tests. There's a follow up task, #20473. |
lhotari
pushed a commit
that referenced
this pull request
Jun 2, 2023
(cherry picked from commit 174c486)
Technoboy-
added a commit
that referenced
this pull request
Jun 26, 2023
liangyepianzhou
pushed a commit
that referenced
this pull request
Jul 7, 2023
(cherry picked from commit 174c486)
nicoloboschi
pushed a commit
to datastax/pulsar
that referenced
this pull request
Jul 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #19330
Motivation
Replace calls to Auth0 with calls to a local WireMock server. The server behaves in essentially the same way as Auth0.
Modifications
Update
TokenOauth2AuthenticatedProducerConsumerTest.Verifying this change
The modified test passes and still covers the same code.
Documentation
doc-not-needed