Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature]Introduce lightweight raw Message metadata #8617

Closed
aloyszhang opened this issue Nov 18, 2020 · 0 comments · Fixed by #8618
Closed

[Feature]Introduce lightweight raw Message metadata #8617

aloyszhang opened this issue Nov 18, 2020 · 0 comments · Fixed by #8618
Labels
type/feature The PR added a new feature or issue requested a new feature

Comments

@aloyszhang
Copy link
Contributor

aloyszhang commented Nov 18, 2020 •
edited
Loading

Is your feature request related to a problem? Please describe.
Introduce lightweight raw Message metadata which does not combine with MessageMetadata to Pulsar.

Describe the solution you'd like
Details about this feature can be found here PIP-70
@aloyszhang aloyszhang added the type/feature The PR added a new feature or issue requested a new feature label Nov 18, 2020
@aloyszhang aloyszhang changed the title Introduce lightweight raw Message metadata [Feature]Introduce lightweight raw Message metadata Nov 18, 2020
@sijie sijie mentioned this issue Nov 18, 2020
Closed
@aloyszhang aloyszhang mentioned this issue Nov 18, 2020
Merged
jiazhai pushed a commit that referenced this issue Dec 12, 2020
@aloyszhang
[PIP 70][Issue 8617] Introduce lightweight broker entry metadata (#8618)
6275297 
Fixes #8617

## Motivation
Introduce lightweight raw Message metadata, details can be found PIP-70

## Modifications
wire protocol add RawMessageMetadata and supports_raw_message_meta for FeatureFlags
change how produced message is saved in bookkeeper: add raw metadata for message
change how message is seek-by-time
change how message send back to Consumer: skip metadata if consumer not supprot raw metadata
Verifying this change
Added tests for parse/skip raw message metadata
Added test for how message seek-by broker timestamp for message
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type/feature The PR added a new feature or issue requested a new feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[PIP 70][Issue 8617] Introduce lightweight broker entry metadata aloyszhang/pulsar
2 participants
@sijie @aloyszhang