Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[improve][broker] Make some methods of ClusterBase pure async. #15318

Merged
merged 4 commits into from
May 4, 2022
Merged

[improve][broker] Make some methods of ClusterBase pure async. #15318

merged 4 commits into from
May 4, 2022

Conversation

mattisonchao
Copy link
Member

@mattisonchao mattisonchao commented Apr 26, 2022 •
edited
Loading

Motivation

See PIP #14365 and change tracker #15043.

Modifications

  • Make ClusterBase getClusters / getCluster / createCluster / updateCluster methods to pure async.

Verifying this change

  • Make sure that the change passes the CI checks.

We have AdminTest covering this change.

Documentation

  • no-need-doc
    (Please explain why)

@mattisonchao mattisonchao mentioned this pull request Apr 26, 2022
Closed
26 tasks
@github-actions github-actions bot added the doc-not-needed Your PR changes do not impact docs label Apr 26, 2022
@mattisonchao
Copy link
Member Author

/pulsarbot rerun-failure-checks

Technoboy-
Technoboy- approved these changes Apr 26, 2022
View reviewed changes
Copy link
Contributor

@Technoboy- Technoboy- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@RobertIndie RobertIndie added type/enhancement The enhancements for the existing features or docs. e.g. reduce memory usage of the delayed messages area/broker area/admin labels Apr 26, 2022
@RobertIndie RobertIndie added this to the 2.11.0 milestone Apr 26, 2022
@mattisonchao
Copy link
Member Author

/pulsarbot rerun-failure-checks

@mattisonchao mattisonchao mentioned this pull request Apr 28, 2022
Merged
2 tasks
@mattisonchao
Copy link
Member Author

/pulsarbot rerun-failure-checks

gaoran10
gaoran10 reviewed Apr 29, 2022
View reviewed changes
Copy link
Contributor

@gaoran10 gaoran10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, left a trivial comment.

pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/impl/ClustersBase.java Show resolved Hide resolved
@mattisonchao mattisonchao merged commit 273446b into apache:master May 4, 2022
@mattisonchao mattisonchao deleted the pip_149_3 branch May 4, 2022 20:13
@sijie sijie mentioned this pull request Aug 1, 2022
Open
26 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shibd shibd shibd approved these changes

@RobertIndie RobertIndie RobertIndie approved these changes

@gaoran10 gaoran10 gaoran10 approved these changes

@Technoboy- Technoboy- Technoboy- approved these changes

Assignees

@mattisonchao mattisonchao

Labels
area/admin area/broker doc-not-needed Your PR changes do not impact docs type/enhancement The enhancements for the existing features or docs. e.g. reduce memory usage of the delayed messages
Projects
None yet
Milestone
2.11.0
Development

Successfully merging this pull request may close these issues.
5 participants
@mattisonchao @Technoboy- @gaoran10 @RobertIndie @shibd