[improve][build] Avoid building image multiple times

[nodece]

Motivation

The current config will build the pulsar and pulsar-all images multiple times.

https://github.com/apache/pulsar/runs/7945037366?check_suite_focus=true#step:10:5675
https://github.com/apache/pulsar/runs/7945037366?check_suite_focus=true#step:10:6760

One is apache/pulsar, and one is without the apache repository, we should only keep an image without the apache repository, it is enough.

When we do release, only use the image without the apache repository. The following commands are from the docker/publish.sh.

docker tag pulsar:latest ${docker_registry_org}/pulsar:latest
docker tag pulsar-all:latest ${docker_registry_org}/pulsar-all:latest

docker tag pulsar:latest ${docker_registry_org}/pulsar:$MVN_VERSION
docker tag pulsar-all:latest ${docker_registry_org}/pulsar-all:$MVN_VERSION

Modifications

• Remove push step and ${docker.organization}/pulsar/${project.version} and ${docker.organization}/pulsar-all/${project.version} images, because we are using the bash script to push image with the latest tag to docker hub, see https://github.com/apache/pulsar/blob/master/wiki/release/release-process.md#publish-docker-images-to-personal-account-in-hubdockercom-if-you-dont-have-access-to-apachepulsar-org
• Use https://dmp.fabric8.io/#docker:tag instead of add-no-repo step

Documentation

Check the box below or label this PR directly.

Need to update docs?

• doc-required
  (Your PR needs to update docs and you will update later)

• doc-not-needed
  (Please explain why)

• doc
  (Your PR contains doc changes)

• doc-complete
  (Docs have been already added)

[lhotari]

I think it's a bad idea to remove tagging with ${project.version} since some custom build could be relying on that.

This PR should be limited to the change that just removes the unnecessary duplication docker build (which seems to be prevented by Docker caching).

[tisonkun]

which seems to be prevented by Docker caching

IIRC in this #17148 (comment) I add a noCache config to keep logic as previous <noCache>true</noCache>. But we can enable it so that there's no need to wire all this logic in this patch.

[nodece]

I think it's a bad idea to remove tagging with ${project.version} since some custom build could be relying on that.

As far as I know, we didn't use ${project.version} image, if you know where using that, please let me know, thanks!

This PR should be limited to the change that just removes the unnecessary duplication docker build (which seems to be prevented by Docker caching).

You are right! But the docker-maven plugin only supports renewing an image name by rebuilding, or using https://dmp.fabric8.io/#docker:tag, but it only supports adding an image name.

which seems to be prevented by Docker caching

Multiple builds can use caching, see https://github.com/apache/pulsar/runs/7945037366?check_suite_focus=true#step:10:6768, this PR just wants to avoid the multiple builds.

We just enable noCache when building the test image. The pulsar, and pulsar-all images always use caching.

[nodece]

/pulsarbot rerun-failure-checks

[tisonkun]

I have no objection to this patch, so approve to merge it. Although, we need to clarify the procedure of publishing:

1. I don't see any -SNAPSHOT version on the dockerhub and suppose the test image refers to latest.
2. The current build and publish process for releasing doesn't depend on maven settings.

[tisonkun]

It seems before and after this change, "Build Pulsar docker image" takes always 25~30 mins to complete.

UPDATE: It's because "Build Pulsar docker image" actually build test images instead of pulsar/pulsar-all images.

[nodece]

Hi @lhotari, @michaeljmarshall, do you have time to review this PR?

[nodece]

Ping @merlimat, could you review this PR?

[github-actions]

The pr had no activity for 30 days, mark with Stale label.

[tisonkun]

Merging...

@lhotari your questions are answered at #17208 (review)