[fix][sql] Exclude jsr305 from objectsize. #17277
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Technoboy-
added
area/sql
mattisonchao
approved these changes
Aug 25, 2022
codelipenghui
approved these changes
Aug 25, 2022
mattisonchao
requested review from
lhotari,
codelipenghui,
nicoloboschi and
shoothzj
Technoboy-
changed the title
Demogorgon314
approved these changes
Aug 25, 2022
tjiuming
approved these changes
Aug 25, 2022
shoothzj
approved these changes
Aug 29, 2022
Technoboy-
force-pushed
the
fix-jsr-version
branch
2 times, most recently
from
03c7b31
to
9fcf07d
Compare
Technoboy-
force-pushed
the
fix-jsr-version
branch
from
9fcf07d
to
7216e1d
Compare
Technoboy-
added a commit
that referenced
this pull request
Aug 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
When check the license of branch-2.11, I find there are two versions of
jsr305:2.0.1depends fromobjectsize, so when build presto-distribution, the version ofjsr305is2.0.13.0.2depends fromspotbugs, so when build presto-pulsar, the version ofjsr305is3.0.2So we have to exclude the lower version.
Documentation
doc-not-needed(Please explain why)