[improve][broker] Improve backlogQuota endpoint to pure async.
#17383
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattisonchao
added
type/enhancement
Technoboy-
approved these changes
Sep 1, 2022
HQebupt
approved these changes
Sep 1, 2022
nodece
reviewed
Sep 1, 2022
pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/v1/Namespaces.java
Outdated
Show resolved
Hide resolved
nodece
reviewed
Sep 1, 2022
pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/v2/Namespaces.java
Outdated
Show resolved
Hide resolved
nodece
reviewed
Sep 1, 2022
pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/impl/NamespacesBase.java
Show resolved
Hide resolved
mattisonchao
commented
Sep 1, 2022
pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/v2/Namespaces.java
Outdated
Show resolved
Hide resolved
mattisonchao
commented
Sep 1, 2022
pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/v1/Namespaces.java
Outdated
Show resolved
Hide resolved
nodece
approved these changes
Sep 1, 2022
gaoran10
approved these changes
Sep 2, 2022
4 tasks
poorbarcode
added a commit
that referenced
this pull request
Jun 30, 2023
…ntion exists (#20690) Motivation: When a retention policy exists, the command `pulsar-admin namespaces set-backlog-quota` does not take effect.In the PR #17383: it only checked the compatibility of `retention` and `backlog quota`, and it was not set. Modifications: Fix the bug. (cherry picked from commit 6acd01d)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Since Pulsar is a fully asynchronous project, we need to avoid using thread-blocking methods.
Also, we can see #14365
Modifications
backlogQuotarelative endpoint to pure async.Verifying this change
Does this pull request potentially affect one of the following parts:
If
yeswas chosen, please highlight the changesDocumentation
Check the box below or label this PR directly.
Need to update docs?
doc-required(Your PR needs to update docs and you will update later)
doc-not-needed(Please explain why)
doc(Your PR contains doc changes)
doc-complete(Docs have been already added)