[improve] [broker] Print warn log if compaction failure #19405
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Now exceptions that happen in the flow of compaction task are collected into variable
currentCompaction
and don't print any log.When compaction doesn't work, two reasons come to mind:
We can't determine which causing the problem if there has no log, this increases the difficulty of troubleshooting.
The API
pulsar-admin topics compaction-status <topic>
lets us see what happens when the last compaction executes, But it can not help us know if there were previous missions that failed.Modifications
Print warn log if compaction fails.
Documentation
doc
doc-required
doc-not-needed
doc-complete
Matching PR in forked repository
PR in forked repository: