Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[optimize][admin]Enhancing Transaction Buffer Stats and Introducing TransactionBufferInternalStats API #20330

Merged
merged 20 commits into from
Jul 22, 2023
Merged

[optimize][admin]Enhancing Transaction Buffer Stats and Introducing TransactionBufferInternalStats API #20330

merged 20 commits into from
Jul 22, 2023

Conversation

liangyepianzhou
Copy link
Contributor

master #20291

Motivation

Our primary goal is to improve the visibility and troubleshooting capabilities of the Pulsar Transaction Buffer by providing more detailed information about the snapshot stats and system topic internal status.

Modifications

  1. Enhance the existing TransactionBufferStats by adding information about snapshot stats, including the capital of the current segment, unseal aborted transaction ID size, and other related data. This will provide better visibility and troubleshooting capabilities for the Pulsar Transaction Buffer.
  2. Introduce a new API for obtaining TransactionBufferInternalStats, allowing users to access the state of the system topic used for storing snapshots. This will facilitate problem investigation and resolution when issues arise with the transaction buffer.

Verifying this change

  • Make sure that the change passes the CI checks.

(Please pick either of the following options)

This change is a trivial rework / code cleanup without any test coverage.

(or)

This change is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(example:)

  • Added integration tests for end-to-end deployment with large payloads (10MB)
  • Extended integration test for recovery after broker failure

Does this pull request potentially affect one of the following parts:

If the box was checked, please highlight the changes

  • Dependencies (add or upgrade a dependency)
  • The public API
  • The schema
  • The default values of configurations
  • The threading model
  • The binary protocol
  • The REST endpoints
  • The admin CLI options
  • The metrics
  • Anything that affects deployment

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

Matching PR in forked repository

PR in forked repository:

@github-actions github-actions bot added the doc-required Your PR changes impact docs and you will update later. label May 16, 2023
@poorbarcode poorbarcode added this to the 3.1.0 milestone May 18, 2023
@poorbarcode poorbarcode added the type/feature The PR added a new feature or issue requested a new feature label May 18, 2023
gaoran10
gaoran10 reviewed Jul 13, 2023
View reviewed changes
pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/impl/TransactionsBase.java Outdated Show resolved Hide resolved
pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/impl/TransactionsBase.java Outdated Show resolved Hide resolved
pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/impl/TransactionsBase.java Outdated Show resolved Hide resolved
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/PersistentTopic.java Show resolved Hide resolved
...ar-broker/src/main/java/org/apache/pulsar/broker/transaction/buffer/AbortedTxnProcessor.java
*/
long getLastSnapshotTimestamps();
TransactionBufferStats generateSnapshotStats(boolean segmentStats);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to add a new method for compatibility?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AbortedTxnProcessor.java was not included in any release. So we don't need to consider the compatibility for it.

pulsar-broker/src/main/java/org/apache/pulsar/broker/transaction/buffer/TransactionBuffer.java Show resolved Hide resolved
gaoran10
gaoran10 approved these changes Jul 14, 2023
View reviewed changes
Copy link
Contributor

@gaoran10 gaoran10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@liangyepianzhou liangyepianzhou merged commit ebfef6d into apache:master Jul 22, 2023
@liangyepianzhou liangyepianzhou deleted the segment_admin branch July 22, 2023 11:06
@liangyepianzhou liangyepianzhou added doc Your PR contains doc changes, no matter whether the changes are in markdown or code files. and removed doc-required Your PR changes impact docs and you will update later. labels Jul 26, 2023
@Anonymitaet
Copy link
Member

Confirmed with @liangyepianzhou, the doc has been added to 3 API docs along with this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Technoboy- Technoboy- Technoboy- left review comments

@poorbarcode poorbarcode poorbarcode approved these changes

@gaoran10 gaoran10 gaoran10 approved these changes

@codelipenghui codelipenghui codelipenghui approved these changes

Assignees

@liangyepianzhou liangyepianzhou

Labels
doc Your PR contains doc changes, no matter whether the changes are in markdown or code files. type/feature The PR added a new feature or issue requested a new feature
Projects
None yet
Milestone
3.1.0
Development

Successfully merging this pull request may close these issues.
6 participants
@liangyepianzhou @Anonymitaet @Technoboy- @codelipenghui @gaoran10 @poorbarcode