-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[fix][meta] Adding the missed bookie id in the registration manager. #20641
Merged
Technoboy-
merged 1 commit into
apache:master
from
mattisonchao:registration_manager/log/patch
Jun 29, 2023
Merged
[fix][meta] Adding the missed bookie id in the registration manager. #20641
Technoboy-
merged 1 commit into
apache:master
from
mattisonchao:registration_manager/log/patch
Jun 29, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattisonchao
added
area/metadata
and removed
doc-not-needed
Your PR changes do not impact docs
labels
Jun 25, 2023
mattisonchao
changed the title
[fix][metadata] Adding the missed bookie id in the registration manager.
[fix][meta] Adding the missed bookie id in the registration manager.
Jun 25, 2023
Technoboy-
approved these changes
Jun 25, 2023
coderzc
approved these changes
Jun 25, 2023
Codecov Report
@@ Coverage Diff @@
## master #20641 +/- ##
============================================
+ Coverage 72.05% 73.32% +1.27%
- Complexity 31718 32116 +398
============================================
Files 1855 1867 +12
Lines 138376 139288 +912
Branches 15198 15266 +68
============================================
+ Hits 99703 102139 +2436
+ Misses 30656 29162 -1494
+ Partials 8017 7987 -30
Flags with carried forward coverage won't be shown. Click here to find out more.
|
lifepuzzlefun
approved these changes
Jun 28, 2023
Technoboy-
pushed a commit
that referenced
this pull request
Jun 29, 2023
Technoboy-
pushed a commit
that referenced
this pull request
Jul 3, 2023
Technoboy-
pushed a commit
that referenced
this pull request
Jul 4, 2023
nicoloboschi
pushed a commit
to datastax/pulsar
that referenced
this pull request
Jul 17, 2023
…pache#20641) (cherry picked from commit c5f2128)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area/metadata
cherry-picked/branch-2.10
cherry-picked/branch-2.11
cherry-picked/branch-3.0
doc-not-needed
Your PR changes do not impact docs
ready-to-test
release/2.10.5
release/2.11.2
release/3.0.1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Adding the missed bookie id in the registration manager.
Modifications
Verifying this change
Documentation
doc
doc-required
doc-not-needed
doc-complete