[fix][schema] Only handle exception when there has #20730
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
--- ### Motivation When seeing the warn log, there should have a reason why it shows. But the cause is empty and the logic is running correctly. We should only print them when the exception not null.
zymap
requested review from
hangc0276,
Technoboy-,
codelipenghui,
congbobo184 and
mattisonchao
coderzc
approved these changes
Jul 6, 2023
hangc0276
approved these changes
Jul 6, 2023
Codecov Report
@@ Coverage Diff @@
## master #20730 +/- ##
============================================
+ Coverage 73.00% 73.15% +0.15%
+ Complexity 32096 3737 -28359
============================================
Files 1868 1868
Lines 138999 139000 +1
Branches 15292 15292
============================================
+ Hits 101479 101691 +212
+ Misses 29485 29257 -228
- Partials 8035 8052 +17
Flags with carried forward coverage won't be shown. Click here to find out more.
|
AnonHxy
approved these changes
Jul 6, 2023
mattisonchao
approved these changes
Jul 6, 2023
Technoboy-
approved these changes
Jul 6, 2023
liangyepianzhou
pushed a commit
that referenced
this pull request
Jul 7, 2023
(cherry picked from commit 881a1f4)
Technoboy-
pushed a commit
that referenced
this pull request
Jul 11, 2023
Technoboy-
pushed a commit
that referenced
this pull request
Aug 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #xyz
Main Issue: #xyz
PIP: #xyz
Motivation
When seeing the warning log, there should have a reason why it shows. But the cause is empty, and the logic is running correctly. We should only print them when the exception is not null.
Modifications
Verifying this change
(Please pick either of the following options)
This change is a trivial rework / code cleanup without any test coverage.
(or)
This change is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)
Does this pull request potentially affect one of the following parts:
If the box was checked, please highlight the changes
Documentation
docdoc-requireddoc-not-neededdoc-completeMatching PR in forked repository
PR in forked repository: