Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix][broker] Fix IndexOutOfBoundsException in the CompactedTopicUtils #20887

Merged
merged 2 commits into from
Jul 26, 2023

Conversation

coderzc
Copy link
Member

@coderzc coderzc commented Jul 26, 2023

Motivation

Fix IndexOutOfBoundsException in the CompactedTopicUtils

Modifications

if entries are empty, then early return

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

Matching PR in forked repository

PR in forked repository:

@coderzc coderzc added this to the 3.1.0 milestone Jul 26, 2023
@github-actions github-actions bot added the doc-not-needed Your PR changes do not impact docs label Jul 26, 2023
@mattisonchao
Copy link
Member

@coderzc
Is it passible add a test to cover it?

@coderzc coderzc added type/bug The PR fixed a bug or issue reported a bug area/broker labels Jul 26, 2023
@BewareMyPower BewareMyPower added the release/blocker Indicate the PR or issue that should block the release until it gets resolved label Jul 26, 2023
@codecov-commenter
Copy link

Codecov Report

Merging #20887 (76b3cb0) into master (69d7a2b) will decrease coverage by 0.04%.
Report is 7 commits behind head on master.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #20887      +/-   ##
============================================
- Coverage     73.17%   73.14%   -0.04%     
- Complexity    32231    32238       +7     
============================================
  Files          1874     1874              
  Lines        139302   139378      +76     
  Branches      15322    15329       +7     
============================================
+ Hits         101934   101947      +13     
- Misses        29311    29363      +52     
- Partials       8057     8068      +11     
Flag Coverage Δ
inttests 24.14% <100.00%> (-0.28%) ⬇️
systests 25.11% <100.00%> (-0.10%) ⬇️
unittests 72.43% <100.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
.../apache/pulsar/compaction/CompactedTopicUtils.java 70.00% <100.00%> (-9.49%) ⬇️

... and 75 files with indirect coverage changes

@coderzc coderzc merged commit a0372f4 into apache:master Jul 26, 2023
46 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/broker area/compaction doc-not-needed Your PR changes do not impact docs release/blocker Indicate the PR or issue that should block the release until it gets resolved type/bug The PR fixed a bug or issue reported a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants