[fix] [doc] Update BookKeeper metadataServiceUri doc #20909
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hangc0276
requested review from
Technoboy-,
codelipenghui,
zymap and
mattisonchao
hangc0276
added
the
doc
github-actions
bot
added
doc-not-needed
mattisonchao
reviewed
Aug 1, 2023
| # - metadataServiceUri=zk+hierarchical://my-zk-1:2181/ledgers | ||
| # - metadataServiceUri=etcd+hierarchical:http://my-etcd:2379 | ||
| # - metadataServiceUri=metadata-store:zk:my-zk-1:2281 | ||
| # If you use metadata-store configuration, you need to configure following items in JVM option: |
There was a problem hiding this comment.
Suggested change
| # If you use metadata-store configuration, you need to configure following items in JVM option: | |
| # If you want to use the Apache Pulsar metadata-store driver, you need to configure the following items in the JVM option: |
There was a problem hiding this comment.
Maybe we should explain why we must set the metadata-store prefix. WDYT? :)
mattisonchao
approved these changes
Aug 1, 2023
coderzc
approved these changes
Aug 3, 2023
Codecov Report
@@ Coverage Diff @@
## master #20909 +/- ##
============================================
- Coverage 73.14% 71.76% -1.38%
+ Complexity 32221 32051 -170
============================================
Files 1874 1875 +1
Lines 139379 144556 +5177
Branches 15328 16217 +889
============================================
+ Hits 101942 103741 +1799
- Misses 29352 32568 +3216
- Partials 8085 8247 +162
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #xyz
Main Issue: #xyz
PIP: #xyz
Motivation
If we want to use
PulsarMetadataClientDriverin BookKeeper server, the document in conf/bookkeeper.conf is confused and it's hard for users to configure the rightmetadataServiceUriformat.Modifications
Add a document in
conf/bookkeeper.confto guide users to configure the rightmetadataServiceUriformat.Verifying this change
(Please pick either of the following options)
This change is a trivial rework / code cleanup without any test coverage.
(or)
This change is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)
Does this pull request potentially affect one of the following parts:
If the box was checked, please highlight the changes
Documentation
docdoc-requireddoc-not-neededdoc-completeMatching PR in forked repository
PR in forked repository: