-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[fix][broker] Fix incorrect number of read compacted entries #20978
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coderzc
requested review from
Technoboy-,
codelipenghui,
gaoran10 and
mattisonchao
August 11, 2023 11:44
coderzc
changed the title
[fix][bug] Fix incorrect number of read compacted entries
[fix][broker] Fix incorrect number of read compacted entries
Aug 11, 2023
coderzc
force-pushed
the
fix_compacted_num
branch
from
August 12, 2023 11:16
f65dbac
to
2748b99
Compare
codelipenghui
approved these changes
Aug 14, 2023
/pulsarbot run-failure-checks |
poorbarcode
approved these changes
Aug 14, 2023
Technoboy-
approved these changes
Aug 14, 2023
Codecov Report
@@ Coverage Diff @@
## master #20978 +/- ##
=============================================
+ Coverage 33.53% 73.13% +39.60%
- Complexity 12174 32253 +20079
=============================================
Files 1621 1875 +254
Lines 126919 139407 +12488
Branches 13851 15329 +1478
=============================================
+ Hits 42561 101955 +59394
+ Misses 78745 29400 -49345
- Partials 5613 8052 +2439
Flags with carried forward coverage won't be shown. Click here to find out more.
|
coderzc
added a commit
that referenced
this pull request
Aug 14, 2023
(cherry picked from commit 63d9eaf)
coderzc
added a commit
that referenced
this pull request
Aug 14, 2023
(cherry picked from commit 63d9eaf)
coderzc
added a commit
that referenced
this pull request
Aug 14, 2023
(cherry picked from commit 63d9eaf)
coderzc
added a commit
that referenced
this pull request
Aug 14, 2023
(cherry picked from commit 63d9eaf)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area/broker
area/compaction
cherry-picked/branch-2.10
cherry-picked/branch-2.11
cherry-picked/branch-3.0
cherry-picked/branch-3.1
doc-not-needed
Your PR changes do not impact docs
release/2.10.6
release/2.11.3
release/3.0.2
release/3.1.1
type/bug
The PR fixed a bug or issue reported a bug
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Currently, the number of read compacted entries is wrong, which is one more than the specified number.
Modifications
Fix incorrect number of read compacted entries.
Verifying this change
(Please pick either of the following options)
This change is a trivial rework / code cleanup without any test coverage.
(or)
This change is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)
Documentation
doc
doc-required
doc-not-needed
doc-complete
Matching PR in forked repository
PR in forked repository: