-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[improve][meta] Improve fault tolerance of blocking calls by supporting timeout #21028
[improve][meta] Improve fault tolerance of blocking calls by supporting timeout #21028
Conversation
@horizonzy Please help take a look, thanks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Line 448 in d06cda6
for (String c : store.getChildren(parent).get()) { |
Here should also be catch
...src/main/java/org/apache/pulsar/metadata/bookkeeper/PulsarLedgerUnderreplicationManager.java
Outdated
Show resolved
Hide resolved
Codecov Report
@@ Coverage Diff @@
## master #21028 +/- ##
=============================================
+ Coverage 33.56% 73.14% +39.58%
- Complexity 12198 32267 +20069
=============================================
Files 1621 1875 +254
Lines 126970 139577 +12607
Branches 13857 15344 +1487
=============================================
+ Hits 42618 102095 +59477
+ Misses 78748 29403 -49345
- Partials 5604 8079 +2475
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Motivation
We've got a lot of blocking calls without a timeout in the BookKeeper metadata plugin. In a bad situation, it will trigger some deadlocks.
Modifications
Verifying this change
Documentation
doc
doc-required
doc-not-needed
doc-complete