Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix][fn] Fix ProducerConfig cannot update error #21037

Merged

Conversation

jiangpengcheng
Copy link
Contributor

Fixes #21036

Main Issue: #xyz

PIP: #xyz

Motivation

while merging existing config with new config for updating, it doesn't check whether the new config has set the ProducerConfig, which makes the merged config always use the ProducerConfig from the existing config

Modifications

set the producerConfig when updating functions/sources if the ProducerConfig is specified

Verifying this change

  • Make sure that the change passes the CI checks.

(Please pick either of the following options)

This change is a trivial rework / code cleanup without any test coverage.

(or)

This change is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(example:)

  • Added integration tests for end-to-end deployment with large payloads (10MB)
  • Extended integration test for recovery after broker failure

Does this pull request potentially affect one of the following parts:

If the box was checked, please highlight the changes

  • Dependencies (add or upgrade a dependency)
  • The public API
  • The schema
  • The default values of configurations
  • The threading model
  • The binary protocol
  • The REST endpoints
  • The admin CLI options
  • The metrics
  • Anything that affects deployment

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

Matching PR in forked repository

PR in forked repository: jiangpengcheng#15

@github-actions github-actions bot added the doc-not-needed Your PR changes do not impact docs label Aug 21, 2023
@Technoboy- Technoboy- added this to the 3.2.0 milestone Aug 21, 2023
@Technoboy-
Copy link
Contributor

Better to add a test

Copy link
Member

@mattisonchao mattisonchao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you mind adding a unit test for this change? :)

@Technoboy- Technoboy- closed this Aug 30, 2023
@Technoboy- Technoboy- reopened this Aug 30, 2023
@jiangpengcheng jiangpengcheng force-pushed the fix_producer_config_update_error branch from ffb6e72 to efaaa71 Compare August 30, 2023 07:22
@jiangpengcheng
Copy link
Contributor Author

jiangpengcheng commented Aug 30, 2023

@Technoboy- @mattisonchao
tests added

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Cannot update the ProducerConfig for functions/sources
4 participants