-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[fix][fn] Fix ProducerConfig cannot update error #21037
Merged
Technoboy-
merged 2 commits into
apache:master
from
jiangpengcheng:fix_producer_config_update_error
Aug 31, 2023
Merged
[fix][fn] Fix ProducerConfig cannot update error #21037
Technoboy-
merged 2 commits into
apache:master
from
jiangpengcheng:fix_producer_config_update_error
Aug 31, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Better to add a test |
mattisonchao
approved these changes
Aug 21, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would you mind adding a unit test for this change? :)
freeznet
approved these changes
Aug 25, 2023
jiangpengcheng
force-pushed
the
fix_producer_config_update_error
branch
from
August 30, 2023 07:22
ffb6e72
to
efaaa71
Compare
@Technoboy- @mattisonchao |
Technoboy-
pushed a commit
that referenced
this pull request
Sep 5, 2023
Technoboy-
pushed a commit
that referenced
this pull request
Sep 5, 2023
Technoboy-
pushed a commit
that referenced
this pull request
Sep 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
cherry-picked/branch-2.11
cherry-picked/branch-3.0
cherry-picked/branch-3.1
doc-not-needed
Your PR changes do not impact docs
ready-to-test
release/2.11.3
release/3.0.2
release/3.1.1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #21036
Main Issue: #xyz
PIP: #xyz
Motivation
while merging existing config with new config for updating, it doesn't check whether the new config has set the
ProducerConfig
, which makes the merged config always use theProducerConfig
from the existing configModifications
set the
producerConfig
when updatingfunctions/sources
if theProducerConfig
is specifiedVerifying this change
(Please pick either of the following options)
This change is a trivial rework / code cleanup without any test coverage.
(or)
This change is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)
Does this pull request potentially affect one of the following parts:
If the box was checked, please highlight the changes
Documentation
doc
doc-required
doc-not-needed
doc-complete
Matching PR in forked repository
PR in forked repository: jiangpengcheng#15