[fix][broker] Fix write duplicate entries into the compacted ledger after RawReader reconnects #21081
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coderzc
force-pushed
the
fix_comapcted_duplicate
branch
from
5d63494
to
be20d49
Compare
Technoboy-
reviewed
Aug 30, 2023
| .topic(topic) | ||
| .enableBatching(false) | ||
| .messageRoutingMode(MessageRoutingMode.SinglePartition) | ||
| .create(); |
coderzc
force-pushed
the
fix_comapcted_duplicate
branch
from
72399ab
to
c6dc10c
Compare
codelipenghui
approved these changes
Sep 1, 2023
| Awaitility.await().untilAsserted(() -> { | ||
| PersistentTopicInternalStats internalStats = admin.topics().getInternalStats(topic, false); | ||
| // Compacted topic ledger should have same number of entry equals to number of unique key. | ||
| Assert.assertEquals(expected.size(), internalStats.compactedLedger.entries); |
There was a problem hiding this comment.
Suggested change
| Assert.assertEquals(expected.size(), internalStats.compactedLedger.entries); | |
| Assert.assertEquals(internalStats.compactedLedger.entries, expected.size()); |
Technoboy-
approved these changes
Sep 3, 2023
Technoboy-
pushed a commit
that referenced
this pull request
Sep 5, 2023
…fter RawReader reconnects (#21081)
4 tasks
coderzc
added a commit
that referenced
this pull request
Sep 20, 2023
…fter RawReader reconnects (#21081)
coderzc
added a commit
that referenced
this pull request
Sep 20, 2023
…fter RawReader reconnects (#21081)
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Currently, the compactor will write duplicate entries into the compacted ledger after RawReader reconnects on phase two.
Modifications
If the messageId read is less than or equal to lastCompactedMessageId then the entry is skipped.
Verifying this change
(Please pick either of the following options)
This change is a trivial rework / code cleanup without any test coverage.
(or)
This change is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)
Does this pull request potentially affect one of the following parts:
If the box was checked, please highlight the changes
Documentation
docdoc-requireddoc-not-neededdoc-completeMatching PR in forked repository
PR in forked repository: