-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[fix][build] Upgrade Guava to 32.1.2-jre #21090
Conversation
But we don't use Gradle for building. May you share more background here why we need this version bump? |
@tisonkun At our company, a user's application (this is a project using Gradle) that included pulsar-client as a dependency failed to build. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
Codecov Report
@@ Coverage Diff @@
## master #21090 +/- ##
=============================================
+ Coverage 33.52% 73.10% +39.57%
- Complexity 12221 32365 +20144
=============================================
Files 1623 1887 +264
Lines 127275 139860 +12585
Branches 13897 15384 +1487
=============================================
+ Hits 42671 102241 +59570
+ Misses 78986 29514 -49472
- Partials 5618 8105 +2487
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Unrelated. But perhaps for further improvements. |
I think we're good at merging this patch. But perhaps I'll ping some more reviewers and wait a bit. Guava is a fundamental dependency while we only bump a patch version we may use more eyes. |
Merging... Thanks for your reports and contribution @massakam! |
Motivation
Upgraded Guava to
32.1.2-jre
. This version includes a fix for an issue where building with Gradle may fail.google/guava@9ed0fa6
Verifying this change
Documentation
doc-not-needed