Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix][build] Upgrade Guava to 32.1.2-jre #21090

Merged
merged 1 commit into from
Aug 30, 2023
Merged

Conversation

massakam
Copy link
Contributor

@massakam massakam commented Aug 30, 2023

Motivation

Upgraded Guava to 32.1.2-jre. This version includes a fix for an issue where building with Gradle may fail.
google/guava@9ed0fa6

Verifying this change

  • Make sure that the change passes the CI checks.

Documentation

  • doc-not-needed

@massakam massakam added area/dependency Pull requests that update a dependency file doc-not-needed Your PR changes do not impact docs ready-to-test labels Aug 30, 2023
@massakam massakam added this to the 3.2.0 milestone Aug 30, 2023
@massakam massakam self-assigned this Aug 30, 2023
@tisonkun
Copy link
Member

where building with Gradle

But we don't use Gradle for building. May you share more background here why we need this version bump?

@massakam
Copy link
Contributor Author

@tisonkun At our company, a user's application (this is a project using Gradle) that included pulsar-client as a dependency failed to build.

Copy link
Member

@tisonkun tisonkun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@codecov-commenter
Copy link

Codecov Report

Merging #21090 (db777cd) into master (6ff83b6) will increase coverage by 39.57%.
Report is 2 commits behind head on master.
The diff coverage is 83.33%.

Impacted file tree graph

@@              Coverage Diff              @@
##             master   #21090       +/-   ##
=============================================
+ Coverage     33.52%   73.10%   +39.57%     
- Complexity    12221    32365    +20144     
=============================================
  Files          1623     1887      +264     
  Lines        127275   139860    +12585     
  Branches      13897    15384     +1487     
=============================================
+ Hits          42671   102241    +59570     
+ Misses        78986    29514    -49472     
- Partials       5618     8105     +2487     
Flag Coverage Δ
inttests 24.20% <0.00%> (+0.09%) ⬆️
systests 25.08% <0.00%> (?)
unittests 72.40% <83.33%> (+40.35%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
...va/org/apache/pulsar/client/impl/ConsumerImpl.java 77.01% <83.33%> (+22.26%) ⬆️

... and 1532 files with indirect coverage changes

@tisonkun
Copy link
Member

Error:  One or more dependencies were identified with vulnerabilities that have a CVSS score greater than or equal to '7.0': 
Error:  
Error:  aerospike-client-bc-4.4.20.jar: CVE-2023-36480(9.8)
Error:  alluxio-core-client-fs-2.7.3.jar: CVE-2023-38889(9.8)
Error:  alluxio-core-common-2.7.3.jar: CVE-2023-38889(9.8)
Error:  avro-protobuf-1.10.2.jar: CVE-2023-37475(7.5)
Error:  clickhouse-jdbc-0.4.6-all.jar/META-INF/maven/com.squareup.okio/okio/pom.xml: CVE-2023-3635(7.5)
Error:  grpc-core-1.37.0.jar: CVE-2023-33953(7.5)
Error:  grpc-protobuf-1.37.0.jar: CVE-2023-33953(7.5)

Unrelated. But perhaps for further improvements.

@tisonkun
Copy link
Member

I think we're good at merging this patch.

But perhaps I'll ping some more reviewers and wait a bit. Guava is a fundamental dependency while we only bump a patch version we may use more eyes.

@tisonkun
Copy link
Member

Merging...

Thanks for your reports and contribution @massakam!

@tisonkun tisonkun merged commit dab5b2f into apache:master Aug 30, 2023
48 of 49 checks passed
@massakam massakam deleted the bump-guava branch August 30, 2023 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/dependency Pull requests that update a dependency file doc-not-needed Your PR changes do not impact docs ready-to-test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants