-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[fix][ml] Fix wrong configuration passed to managed ledger when deleting #21529
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it possible to add a test to avoid regressions?
I am unsure at first glance. I think the test is challenging to add. I am considering whether it is worth to spend that time. :/ @codelipenghui, do you think this test is necessary? I mean the problem looks pretty straightforward. |
I will add the test to avoid regression. :) |
|
Motivation
#21093 Delete the topic policy before the managed ledger configuration building. It will pass the wrong managed ledger configuration to the backend and affect offloading etc.
Modifications
Verifying this change
Documentation
doc
doc-required
doc-not-needed
doc-complete