[fix] [broker] Enabling batch causes negative unackedMessages due to ack and delivery concurrency #22090
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ack and delivery concurrency.
poorbarcode
added
type/bug
|
Some tests are failed due to this fix |
passes |
dao-jun
approved these changes
Feb 24, 2024
Technoboy-
approved these changes
Feb 25, 2024
Technoboy-
pushed a commit
that referenced
this pull request
Feb 26, 2024
…ack and delivery concurrency (#22090)
Technoboy-
pushed a commit
that referenced
this pull request
Feb 27, 2024
…ack and delivery concurrency (#22090)
mukesh-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Mar 1, 2024
…ack and delivery concurrency (apache#22090) (cherry picked from commit aa3f53b)
mukesh-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Mar 6, 2024
…ack and delivery concurrency (apache#22090) (cherry picked from commit aa3f53b)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Context:
Issue:
c1andc2c1received a batch message:ledger: L1, entry: E1, batch-size: 100.c1was closed, after leaving an in-progress task to acknowledge{L1, E1, batch_index: 1}{L1, E1}and tries to delivery toc2.{L1, E1, batch_index: 1}is finished.c2gets100messages, butunackedMessagesofc2is98.We can always get the warn logs like below:
Modifications
Fix the bug.
Documentation
docdoc-requireddoc-not-neededdoc-completeMatching PR in forked repository
PR in forked repository: x