Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fix][offload] Fix Offload readHandle cannot close multi times. #22162

Merged
merged 6 commits into from
Feb 29, 2024
Merged

[fix][offload] Fix Offload readHandle cannot close multi times. #22162

merged 6 commits into from
Feb 29, 2024

Conversation

dao-jun
Copy link
Member

@dao-jun dao-jun commented Feb 29, 2024 •
edited
Loading

Fixes #22035

Main Issue: #xyz

PIP: #xyz

Motivation

Make FileStoreBackedReadHandleImpl, BlobStoreBackedReadHandleImpl and BlobStoreBackedReadHandleImplV2
closeAsync method can be called multi times.

Modifications

Verifying this change

  • Make sure that the change passes the CI checks.

(Please pick either of the following options)

This change is a trivial rework / code cleanup without any test coverage.

(or)

This change is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(example:)

  • Added integration tests for end-to-end deployment with large payloads (10MB)
  • Extended integration test for recovery after broker failure

Does this pull request potentially affect one of the following parts:

If the box was checked, please highlight the changes

  • Dependencies (add or upgrade a dependency)
  • The public API
  • The schema
  • The default values of configurations
  • The threading model
  • The binary protocol
  • The REST endpoints
  • The admin CLI options
  • The metrics
  • Anything that affects deployment

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

Matching PR in forked repository

PR in forked repository: dao-jun#9

@dao-jun dao-jun added type/bug The PR fixed a bug or issue reported a bug area/tieredstorage labels Feb 29, 2024
@dao-jun dao-jun added this to the 3.3.0 milestone Feb 29, 2024
@dao-jun dao-jun self-assigned this Feb 29, 2024
@github-actions github-actions bot added the doc-not-needed Your PR changes do not impact docs label Feb 29, 2024
This was referenced Feb 29, 2024
Closed
Closed
@dao-jun dao-jun closed this Feb 29, 2024
@dao-jun dao-jun reopened this Feb 29, 2024
lhotari
lhotari approved these changes Feb 29, 2024
View reviewed changes
Copy link
Member

@lhotari lhotari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Good work @dao-jun

@dao-jun
Copy link
Member Author

dao-jun commented Feb 29, 2024

all the ci checks passed, merging...

@dao-jun dao-jun merged commit e25c7f0 into apache:master Feb 29, 2024
50 checks passed
heesung-sn pushed a commit that referenced this pull request Feb 29, 2024
@dao-jun @heesung-sn
[fix][offload] Fix Offload readHandle cannot close multi times. (#22162)
9292b05 
(cherry picked from commit e25c7f0)
gaoran10 pushed a commit that referenced this pull request Mar 4, 2024
@dao-jun @gaoran10
[fix][offload] Fix Offload readHandle cannot close multi times. (#22162)
62de4a5 
(cherry picked from commit e25c7f0)
mukesh-ctds pushed a commit to datastax/pulsar that referenced this pull request Mar 4, 2024
@dao-jun @mukesh-ctds
[fix][offload] Fix Offload readHandle cannot close multi times. (apac…
e2984d6 
…he#22162)

(cherry picked from commit e25c7f0)
(cherry picked from commit 62de4a5)
mukesh-ctds pushed a commit to datastax/pulsar that referenced this pull request Mar 6, 2024
@dao-jun @mukesh-ctds
[fix][offload] Fix Offload readHandle cannot close multi times. (apac…
127a6f0 
…he#22162)

(cherry picked from commit e25c7f0)
(cherry picked from commit 62de4a5)
Technoboy- pushed a commit that referenced this pull request Mar 13, 2024
@dao-jun @Technoboy-
[fix][offload] Fix Offload readHandle cannot close multi times. (#22162)
5551e1b
@dao-jun dao-jun deleted the fix/offload_handle_close_multi_times branch March 27, 2024 06:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Technoboy- Technoboy- Technoboy- approved these changes

@lhotari lhotari lhotari approved these changes

@hangc0276 hangc0276 Awaiting requested review from hangc0276

@zymap zymap Awaiting requested review from zymap

Assignees

@dao-jun dao-jun

Labels
area/tieredstorage cherry-picked/branch-3.0 cherry-picked/branch-3.1 cherry-picked/branch-3.2 doc-not-needed Your PR changes do not impact docs ready-to-test release/3.0.3 release/3.1.3 release/3.2.2 type/bug The PR fixed a bug or issue reported a bug
Projects
None yet
Milestone
3.3.0
Development

Successfully merging this pull request may close these issues.
5 participants
@dao-jun @lhotari @Technoboy- @gaoran10 @heesung-sn