-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[improve][fn] Add configuration for connector & functions package url sources #22184
Merged
gaoran10
merged 1 commit into
apache:master
from
lhotari:lh-add-config-for-package-sources
Mar 4, 2024
Merged
[improve][fn] Add configuration for connector & functions package url sources #22184
gaoran10
merged 1 commit into
apache:master
from
lhotari:lh-add-config-for-package-sources
Mar 4, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lhotari
requested review from
Technoboy-,
eolivelli,
codelipenghui and
nicoloboschi
March 4, 2024 07:22
@lhotari Please add the following content to your PR description and select a checkbox:
|
Technoboy-
added
doc-not-needed
Your PR changes do not impact docs
and removed
doc-label-missing
labels
Mar 4, 2024
codelipenghui
approved these changes
Mar 4, 2024
liangyepianzhou
approved these changes
Mar 4, 2024
eolivelli
approved these changes
Mar 4, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm
Technoboy-
added
release/3.2.1
release/3.0.4
release/3.1.4
release/3.1.3
release/2.10.7
release/2.11.5
and removed
release/3.1.4
labels
Mar 4, 2024
Technoboy-
approved these changes
Mar 4, 2024
Technoboy-
force-pushed
the
lh-add-config-for-package-sources
branch
from
March 4, 2024 14:39
b88585c
to
9bb3dcc
Compare
This was referenced Mar 4, 2024
mukesh-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Mar 5, 2024
… sources (apache#22184) (cherry picked from commit 207335a) (cherry picked from commit b183492)
mukesh-ctds
added a commit
to datastax/pulsar
that referenced
this pull request
Mar 5, 2024
…kage url sources (apache#22184)" This reverts commit 2d19267.
mukesh-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Mar 6, 2024
… sources (apache#22184) (cherry picked from commit 207335a) (cherry picked from commit b183492)
mukesh-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Mar 6, 2024
… sources (apache#22184) (cherry picked from commit 207335a) (cherry picked from commit b183492)
nikhil-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Mar 11, 2024
… sources (apache#22184) (cherry picked from commit 207335a) (cherry picked from commit b107387) (cherry picked from commit b83dab5) Conflicts: pulsar-functions/worker/src/main/java/org/apache/pulsar/functions/worker/FunctionActioner.java pulsar-functions/worker/src/main/java/org/apache/pulsar/functions/worker/rest/api/ComponentImpl.java pulsar-functions/worker/src/main/java/org/apache/pulsar/functions/worker/rest/api/FunctionsImpl.java pulsar-functions/worker/src/test/java/org/apache/pulsar/functions/worker/FunctionActionerTest.java
nikhil-ctds
added a commit
to datastax/pulsar
that referenced
this pull request
Mar 11, 2024
4 tasks
nikhil-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Mar 11, 2024
… sources (apache#22184) (cherry picked from commit 207335a) (cherry picked from commit b107387) (cherry picked from commit b83dab5) Conflicts: pulsar-functions/worker/src/main/java/org/apache/pulsar/functions/worker/FunctionActioner.java pulsar-functions/worker/src/main/java/org/apache/pulsar/functions/worker/rest/api/ComponentImpl.java pulsar-functions/worker/src/main/java/org/apache/pulsar/functions/worker/rest/api/FunctionsImpl.java pulsar-functions/worker/src/test/java/org/apache/pulsar/functions/worker/FunctionActionerTest.java
nikhil-ctds
added a commit
to datastax/pulsar
that referenced
this pull request
Mar 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Currently the configuration is missing for enabling and disabling connector and function package url sources.
Modifications
Add configuration for enabling connector and functions package urls in functions_worker.yml
Add checking of package urls in required locations in Function Worker code
doc
doc-required
doc-not-needed
doc-complete