-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[fix] [client] PIP-344 Do not create partitioned metadata when calling pulsarClient.getPartitionsForTopic(topicName) #22206
Merged
poorbarcode
merged 9 commits into
apache:master
from
poorbarcode:fix/create_metadata_when_calling_get_metadata
May 23, 2024
Merged
[fix] [client] PIP-344 Do not create partitioned metadata when calling pulsarClient.getPartitionsForTopic(topicName) #22206
poorbarcode
merged 9 commits into
apache:master
from
poorbarcode:fix/create_metadata_when_calling_get_metadata
May 23, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
Technoboy-
reviewed
Mar 7, 2024
poorbarcode
force-pushed
the
fix/create_metadata_when_calling_get_metadata
branch
from
May 2, 2024 16:53
4c09019
to
5e7372b
Compare
Technoboy-
reviewed
May 6, 2024
Technoboy-
reviewed
May 6, 2024
pulsar-client/src/main/java/org/apache/pulsar/client/impl/PulsarClientImpl.java
Outdated
Show resolved
Hide resolved
Technoboy-
reviewed
May 7, 2024
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/ServerCnx.java
Outdated
Show resolved
Hide resolved
pulsar-client/src/main/java/org/apache/pulsar/client/impl/LookupService.java
Show resolved
Hide resolved
pulsar-client-api/src/main/java/org/apache/pulsar/client/api/PulsarClient.java
Outdated
Show resolved
Hide resolved
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/ServerCnx.java
Outdated
Show resolved
Hide resolved
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/ServerCnx.java
Outdated
Show resolved
Hide resolved
pulsar-broker/src/test/java/org/apache/pulsar/broker/admin/GetPartitionMetadataTest.java
Show resolved
Hide resolved
pulsar-broker/src/test/java/org/apache/pulsar/broker/admin/GetPartitionMetadataTest.java
Outdated
Show resolved
Hide resolved
poorbarcode
force-pushed
the
fix/create_metadata_when_calling_get_metadata
branch
from
May 20, 2024 17:18
20ce22e
to
5ba345d
Compare
codelipenghui
approved these changes
May 21, 2024
/pulsarbot run-failure-checks |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #22206 +/- ##
============================================
- Coverage 73.57% 73.17% -0.40%
- Complexity 32624 32882 +258
============================================
Files 1877 1890 +13
Lines 139502 141491 +1989
Branches 15299 15525 +226
============================================
+ Hits 102638 103537 +899
- Misses 28908 29941 +1033
- Partials 7956 8013 +57
Flags with carried forward coverage won't be shown. Click here to find out more.
|
gaoran10
reviewed
May 21, 2024
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/ServerCnx.java
Show resolved
Hide resolved
pulsar-client-api/src/main/java/org/apache/pulsar/client/api/PulsarClient.java
Outdated
Show resolved
Hide resolved
Technoboy-
approved these changes
May 21, 2024
poorbarcode
force-pushed
the
fix/create_metadata_when_calling_get_metadata
branch
from
May 22, 2024 04:22
16eea03
to
f7a4805
Compare
poorbarcode
force-pushed
the
fix/create_metadata_when_calling_get_metadata
branch
from
May 22, 2024 04:23
f7a4805
to
2c6e826
Compare
Rebase master |
gaoran10
approved these changes
May 22, 2024
nikhil-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Jun 24, 2024
…g pulsarClient.getPartitionsForTopic(topicName) (apache#22206) (cherry picked from commit 4e5c0bc) (cherry picked from commit 9e59dd0)
nikhil-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Jun 24, 2024
…g pulsarClient.getPartitionsForTopic(topicName) (apache#22206) (cherry picked from commit 4e5c0bc) (cherry picked from commit 9e59dd0)
nikhil-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Jun 24, 2024
…g pulsarClient.getPartitionsForTopic(topicName) (apache#22206) (cherry picked from commit 4e5c0bc) (cherry picked from commit 9e59dd0)
nikhil-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Jun 25, 2024
…g pulsarClient.getPartitionsForTopic(topicName) (apache#22206) (cherry picked from commit 4e5c0bc) (cherry picked from commit 9e59dd0)
srinath-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Jul 1, 2024
…g pulsarClient.getPartitionsForTopic(topicName) (apache#22206) (cherry picked from commit 4e5c0bc) (cherry picked from commit 9e59dd0)
There's a reported bug #23203 which is related to this change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
cherry-picked/branch-3.0
cherry-picked/branch-3.3
doc-not-needed
Your PR changes do not impact docs
ready-to-test
release/3.0.6
release/3.3.1
type/bug
The PR fixed a bug or issue reported a bug
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
see also PIP-344 Correct the behavior of the public API pulsarClient.getPartitionsForTopic(topicName)
Background
pulsarClient.getPartitionsForTopic(topicName)
, Pulsar will automatically create the partitioned topic metadata if it does not exist, either usingHttpLookupService
orBinaryProtoLookupService
.pulsarClient.getPartitionsForTopic
pulsarClient.getPartitionsForTopic
Issue
Since the method
pulsarClient.getPartitionsForTopic
is a public API, and it is namedgetxxx,
it should edit nothing.Modifications
Next PRs
Documentation
doc
doc-required
doc-not-needed
doc-complete
Matching PR in forked repository
PR in forked repository: x