[improve][misc] Remove the call to sun InetAddressCachePolicy #22329
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…urity standard parameters
github-actions
bot
added
the
doc-complete
lhotari
reviewed
Mar 22, 2024
pulsar-common/src/main/java/org/apache/pulsar/common/util/netty/DnsResolverUtil.java
Outdated
Show resolved
Hide resolved
pulsar-common/src/main/java/org/apache/pulsar/common/util/netty/DnsResolverUtil.java
Show resolved
Hide resolved
pulsar-common/src/test/java/org/apache/pulsar/common/util/netty/DnsResolverTest.java
Outdated
Show resolved
Hide resolved
pulsar-common/src/test/java/org/apache/pulsar/common/util/netty/DnsResolverTest.java
Outdated
Show resolved
Hide resolved
…y/DnsResolverTest.java Co-authored-by: Lari Hotari <[email protected]>
lhotari
reviewed
Mar 25, 2024
pulsar-common/src/test/java/org/apache/pulsar/common/util/netty/DnsResolverTest.java
Outdated
Show resolved
Hide resolved
lhotari
reviewed
Mar 25, 2024
pulsar-common/src/main/java/org/apache/pulsar/common/util/netty/DnsResolverUtil.java
Outdated
Show resolved
Hide resolved
lhotari
changed the title
lhotari
pushed a commit
that referenced
this pull request
Mar 27, 2024
Co-authored-by: Lari Hotari <[email protected]> (cherry picked from commit cce0b05)
lhotari
pushed a commit
that referenced
this pull request
Mar 27, 2024
Co-authored-by: Lari Hotari <[email protected]> (cherry picked from commit cce0b05)
Technoboy-
pushed a commit
to Technoboy-/pulsar
that referenced
this pull request
Apr 1, 2024
…#22329) Co-authored-by: Lari Hotari <[email protected]>
This was referenced Apr 2, 2024
|
It was great that this change was made. It revealed a long time bug in the Dockerfile used in Pulsar 3.0.x, 3.1.x and 3.2.x versions. More explanation in comment #22400 (comment) . |
mukesh-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Apr 15, 2024
…#22329) Co-authored-by: Lari Hotari <[email protected]> (cherry picked from commit cce0b05) (cherry picked from commit 1b9ae2e)
mukesh-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Apr 17, 2024
…#22329) Co-authored-by: Lari Hotari <[email protected]> (cherry picked from commit cce0b05) (cherry picked from commit 1b9ae2e)
mukesh-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Apr 17, 2024
…#22329) Co-authored-by: Lari Hotari <[email protected]> (cherry picked from commit cce0b05) (cherry picked from commit 1b9ae2e)
mukesh-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Apr 19, 2024
…#22329) Co-authored-by: Lari Hotari <[email protected]> (cherry picked from commit cce0b05) (cherry picked from commit 1b9ae2e)
srinath-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Apr 23, 2024
…#22329) Co-authored-by: Lari Hotari <[email protected]> (cherry picked from commit cce0b05) (cherry picked from commit 1b9ae2e)
This was referenced Jun 14, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Main Issue: #20282
Motivation
I'm presently working with Spring Boot 3 and JDK 17. While utilizing Pulsar, I encountered an error indicating that reflection on content under the 'sun' package is restricted. After reviewing Pulsar-related issues, I found a suggestion to resolve this by using
--add-opens java.base/sun.net=ALL-UNNAMED. However, this workaround isn't suitable and doesn't effectively address the issue. Hence, I've created this PR.Modifications
The environment variables
networkaddress.cache.ttlandnetworkaddress.cache.negative.ttlare standard configurations for obtaining related settings for security purposes.I've made modifications to the
org.apache.pulsar.common.util.netty.DnsResolverUtilmethod, eliminating its dependency on thesun.net.InetAddressCachePolicyclass for obtaining DNS TTL. Thesun.net.InetAddressCachePolicyclass is currently removal.java early_access jdk net-properties
oracle jdk8 net-properties
Verifying this change
This change added tests and can be verified as follows:
Does this pull request potentially affect one of the following parts:
If the box was checked, please highlight the changes
Documentation
docdoc-requireddoc-not-neededdoc-completeMatching PR in forked repository
PR in forked repository: