[improve][admin] Align the auth and check it at the first place for topic related API #22342
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Technoboy-
added
ready-to-test
doc-not-needed
Technoboy-
changed the title
coderzc
approved these changes
Apr 1, 2024
liangyepianzhou
approved these changes
Apr 1, 2024
Technoboy-
added a commit
to Technoboy-/pulsar
that referenced
this pull request
Apr 1, 2024
|
@Technoboy- I guess it makes sense to cherry-pick to 3.0.x and 3.2.x to reduce the chances of merge conflicts for future maintenance? |
2 tasks
+1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The main thing is to align the auth operation and put the auth checking operation at the first position.
Modifications
getPartitionedTopicMetadat,internalGetPropertiesAsync,internalUpdatePropertiesAsync,internalRemovePropertiesAsync,internalDeletePartitionedTopic,internalGetSubscriptions,internalGetStatsAsync,internalSkipMessages,internalSkipAllMessages,internalPeekNthMessageAsync,internalExamineMessageAsync,internalExpireMessagesByPosition,internalResetCursorAsync,internalResetCursorOnPosition,internalGetMessageById,internalExpireMessagesByTimestampAnd add related auth test.
Documentation
docdoc-requireddoc-not-neededdoc-complete