[improve] [broker] Create partitioned topics automatically when enable topic level replication #22537
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
poorbarcode
requested review from
nodece,
Demogorgon314,
liudezhi2098 and
liangyepianzhou
pulsar-broker/src/test/java/org/apache/pulsar/broker/service/OneWayReplicatorTest.java
Outdated
Show resolved
Hide resolved
pulsar-broker/src/test/java/org/apache/pulsar/broker/service/OneWayReplicatorTest.java
Show resolved
Hide resolved
Demogorgon314
approved these changes
Apr 22, 2024
gaoran10
reviewed
Apr 22, 2024
pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/AdminResource.java
Show resolved
Hide resolved
gaoran10
approved these changes
Apr 23, 2024
poorbarcode
force-pushed
the
repl/PR_22203
branch
from
7491055
to
558f1a3
Compare
|
Rebase master |
15 tasks
4 tasks
4 tasks
nikhil-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
May 13, 2024
…e topic level replication (apache#22537) (cherry picked from commit d475655) (cherry picked from commit 076b55e)
srinath-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
May 16, 2024
…e topic level replication (apache#22537) (cherry picked from commit d475655) (cherry picked from commit 076b55e)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
pulsar-admin topics create-partitioned-topicunder a namespace that enabled GEO-Replication.pulsar-admin topics set-replication-clusters.So far, Brokers will create remote partitioned topics on namespace level GEO-Replication but do not create remote partitioned topics on topic level GEO-Replication.
This PR wants to fix the same issue that #22203 is trying to fix, since the codes of #22203 have been in conflict with
branch-masterand it was not active for a long time, I created the current PR.Modifications
Topic level Geo-Replication
PRECONDITION_FAILEDerror if the partitioned topic with different partitions on the remote cluster already exists.Namespace level Geo-Replication
Next PR
When calling
pulsar-admin topics create-partitioned-topicunder a namespace that was enabled GEO-Replication, the broker will respond with aPRECONDITION_FAILEDif the partitioned topic with different partitions on the remote cluster already exists. For now, it responds a 200 success. See the testtestNamespaceLevelReplicationRemoteConflictTopicExistDocumentation
docdoc-requireddoc-not-neededdoc-completeMatching PR in forked repository
PR in forked repository: x