Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[improve][client] Add maxConnectionsPerHost and connectionMaxIdleSeconds to PulsarAdminBuilder #22541

Merged
merged 21 commits into from
Aug 8, 2024
Merged

[improve][client] Add maxConnectionsPerHost and connectionMaxIdleSeconds to PulsarAdminBuilder #22541

merged 21 commits into from
Aug 8, 2024

Commits on Aug 7, 2024

  1. [improve][client] Add connectionsPerHost and connectionMaxIdleSeconds… 

    … to PulsarAdminBuilder

- also modify the default connectionMaxIdleSeconds from 60 seconds to 25 seconds
  - some firewalls/NATs have a timeout of 30 seconds and that's why 25 seconds is a better default
    - common firewall/NAT idle timeout is 60 seconds and since the check isn't absolute, a better
      default is 25 seconds to ensure that connections don't die because of firewall/NAT timeouts
    @lhotari
    lhotari committed Aug 7, 2024
    Configuration menu
    Copy the full SHA
    c8295b7 View commit details
    Browse the repository at this point in the history

  2. Rename connectionsPerHost -> maxConnectionsPerHost

    @lhotari
    lhotari committed Aug 7, 2024
    Configuration menu
    Copy the full SHA
    8605273 View commit details
    Browse the repository at this point in the history

  3. Add test for specifying maxConnectionsPerHost with loadConf

    @lhotari
    lhotari committed Aug 7, 2024
    Configuration menu
    Copy the full SHA
    c0c01c2 View commit details
    Browse the repository at this point in the history

  4. Upgrade Jersey to 2.42 

    - includes support for cancelling async requests
  eclipse-ee4j/jersey#5542
    @lhotari
    lhotari committed Aug 7, 2024
    Configuration menu
    Copy the full SHA
    f5e5eec View commit details
    Browse the repository at this point in the history

  5. Add completable-futures dependency

    @lhotari
    lhotari committed Aug 7, 2024
    Configuration menu
    Copy the full SHA
    18eee3d View commit details
    Browse the repository at this point in the history

  6. Use ConcurrencyReducer to limit concurrency per host

    @lhotari
    lhotari committed Aug 7, 2024
    Configuration menu
    Copy the full SHA
    e03bb1f View commit details
    Browse the repository at this point in the history

  7. Handle redirects so that the concurrency limiter could work with redi… 

    …rects
    @lhotari
    lhotari committed Aug 7, 2024
    Configuration menu
    Copy the full SHA
    24dc470 View commit details
    Browse the repository at this point in the history

  8. Add MaxRedirectException

    @lhotari
    lhotari committed Aug 7, 2024
    Configuration menu
    Copy the full SHA
    b2e420d View commit details
    Browse the repository at this point in the history

  9. Remove redundant code

    @lhotari
    lhotari committed Aug 7, 2024
    Configuration menu
    Copy the full SHA
    f798673 View commit details
    Browse the repository at this point in the history

  10. Support access directly to AsyncHttpClient which limits concurrency

    @lhotari
    lhotari committed Aug 7, 2024
    Configuration menu
    Copy the full SHA
    1f007a5 View commit details
    Browse the repository at this point in the history

  11. Fix test after modifying connectionMaxIdleSeconds minimum

    @lhotari
    lhotari committed Aug 7, 2024
    Configuration menu
    Copy the full SHA
    7b2b93a View commit details
    Browse the repository at this point in the history

  12. Specify acquireFreeChannelTimeout when maxConnectionsPerHost is set

    @lhotari
    lhotari committed Aug 7, 2024
    Configuration menu
    Copy the full SHA
    c7f39a0 View commit details
    Browse the repository at this point in the history

  13. Fix CodeQL java/netty-http-request-or-response-splitting issue

    @lhotari
    lhotari committed Aug 7, 2024
    Configuration menu
    Copy the full SHA
    4a2c01f View commit details
    Browse the repository at this point in the history

Commits on Aug 8, 2024

  1. Refactor configuration logic in AsyncHttpConnector

    @lhotari
    lhotari committed Aug 8, 2024
    Configuration menu
    Copy the full SHA
    12dd71d View commit details
    Browse the repository at this point in the history

  2. Add test for max redirects

    @lhotari
    lhotari committed Aug 8, 2024
    Configuration menu
    Copy the full SHA
    370c7af View commit details
    Browse the repository at this point in the history

  3. Add tests for redirects

    @lhotari
    lhotari committed Aug 8, 2024
    Configuration menu
    Copy the full SHA
    3469372 View commit details
    Browse the repository at this point in the history

  4. Add comment about retries in AsyncHttpConnector

    @lhotari
    lhotari committed Aug 8, 2024
    Configuration menu
    Copy the full SHA
    609629c View commit details
    Browse the repository at this point in the history

  5. Fix implementation of possibly unused "apply" method

    @lhotari
    lhotari committed Aug 8, 2024
    Configuration menu
    Copy the full SHA
    6a18bbb View commit details
    Browse the repository at this point in the history

  6. Add test for max connections

    @lhotari
    lhotari committed Aug 8, 2024
    Configuration menu
    Copy the full SHA
    ec9e724 View commit details
    Browse the repository at this point in the history

  7. Add Javadocs to AsyncHttpRequestExecutor

    @lhotari
    lhotari committed Aug 8, 2024
    Configuration menu
    Copy the full SHA
    e7c961a View commit details
    Browse the repository at this point in the history

  8. Unwrap exception

    @lhotari
    lhotari committed Aug 8, 2024
    Configuration menu
    Copy the full SHA
    fb374eb View commit details
    Browse the repository at this point in the history