Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix][admin] Fix namespace admin api exception response #22587

Merged
merged 3 commits into from
Apr 26, 2024

Conversation

coderzc
Copy link
Member

@coderzc coderzc commented Apr 25, 2024

Motivation

Namespace admin API should return NotAuthorizedException when verification of permissions failed, but SetOffloadThresholdInSeconds return ServerSideErrorException.

Modifications

  • Return correct exception response.
  • Using validateNamespacePolicyOperation instead of validateNamespacePolicyOperationAsync to avoid exceptions being ignored

Verifying this change

  • Make sure that the change passes the CI checks.

(Please pick either of the following options)

This change is a trivial rework / code cleanup without any test coverage.

(or)

This change is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(example:)

  • Added integration tests for end-to-end deployment with large payloads (10MB)
  • Extended integration test for recovery after broker failure

Does this pull request potentially affect one of the following parts:

If the box was checked, please highlight the changes

  • Dependencies (add or upgrade a dependency)
  • The public API
  • The schema
  • The default values of configurations
  • The threading model
  • The binary protocol
  • The REST endpoints
  • The admin CLI options
  • The metrics
  • Anything that affects deployment

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

Matching PR in forked repository

PR in forked repository:

@coderzc coderzc requested a review from Technoboy- April 25, 2024 15:13
@github-actions github-actions bot added the doc-not-needed Your PR changes do not impact docs label Apr 25, 2024
@Technoboy- Technoboy- merged commit f25776d into apache:master Apr 26, 2024
49 of 50 checks passed
coderzc added a commit that referenced this pull request Apr 26, 2024
coderzc added a commit that referenced this pull request Apr 26, 2024
nikhil-ctds pushed a commit to datastax/pulsar that referenced this pull request May 13, 2024
(cherry picked from commit f25776d)
(cherry picked from commit 5ffec8a)
srinath-ctds pushed a commit to datastax/pulsar that referenced this pull request May 16, 2024
(cherry picked from commit f25776d)
(cherry picked from commit 5ffec8a)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants