Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[improve][broker] Propagate cause exception in TopicBusyException when applicable #22596

Merged
merged 1 commit into from
Apr 26, 2024
Merged

[improve][broker] Propagate cause exception in TopicBusyException when applicable #22596

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions pulsar-broker/src/main/java/org/apache/pulsar/broker/service/BrokerServiceException.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -146,6 +146,10 @@ public static class TopicBusyException extends BrokerServiceException {
public TopicBusyException(String msg) {
super(msg);
}

public TopicBusyException(String msg, Throwable t) {
super(msg, t);
}
}

public static class TopicNotFoundException extends BrokerServiceException {
Expand Down
3 changes: 2 additions & 1 deletion ...oker/src/main/java/org/apache/pulsar/broker/service/nonpersistent/NonPersistentTopic.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -477,7 +477,8 @@ private CompletableFuture<Void> delete(boolean failIfHasSubscriptions, boolean c
}
}).exceptionally(ex -> {
deleteFuture.completeExceptionally(
new TopicBusyException("Failed to close clients before deleting topic."));
new TopicBusyException("Failed to close clients before deleting topic.",
FutureUtil.unwrapCompletionException(ex)));
return null;
});
} finally {
Expand Down
3 changes: 2 additions & 1 deletion pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/PersistentTopic.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1506,7 +1506,8 @@ public void deleteLedgerComplete(Object ctx) {
}).exceptionally(ex->{
unfenceTopicToResume();
deleteFuture.completeExceptionally(
new TopicBusyException("Failed to close clients before deleting topic."));
new TopicBusyException("Failed to close clients before deleting topic.",
FutureUtil.unwrapCompletionException(ex)));
return null;
});

Expand Down
Loading