-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[fix] [broker] rename to changeMaxReadPositionCount #22656
[fix] [broker] rename to changeMaxReadPositionCount #22656
Conversation
@thetumbled Please add the following content to your PR description and select a checkbox:
|
PTAL, thanks. @lhotari @congbobo184 @liangyepianzhou @poorbarcode |
...r/src/main/java/org/apache/pulsar/broker/transaction/buffer/impl/TopicTransactionBuffer.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/pulsarbot rerun-failure-checks |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #22656 +/- ##
============================================
- Coverage 73.57% 73.12% -0.45%
+ Complexity 32624 2401 -30223
============================================
Files 1877 1887 +10
Lines 139502 141068 +1566
Branches 15299 15482 +183
============================================
+ Hits 102638 103163 +525
- Misses 28908 29925 +1017
- Partials 7956 7980 +24
Flags with carried forward coverage won't be shown. Click here to find out more.
|
(cherry picked from commit 5ab0512)
(cherry picked from commit 5ab0512)
Motivation
Though
changeMaxReadPositionAndAddAbortTimes
is described as: increment when change the max read position or add a abort txn.In inplementation, we only increment it when change the max read position.
Modifications
Rename
changeMaxReadPositionAndAddAbortTimes
tochangeMaxReadPositionTimes
.Verifying this change
(Please pick either of the following options)
This change is a trivial rework / code cleanup without any test coverage.
Does this pull request potentially affect one of the following parts:
If the box was checked, please highlight the changes
Documentation
doc
doc-required
doc-not-needed
doc-complete
Matching PR in forked repository
PR in forked repository: