Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] [broker] rename to changeMaxReadPositionCount #22656

Conversation

thetumbled
Copy link
Member

@thetumbled thetumbled commented May 6, 2024

Motivation

Though changeMaxReadPositionAndAddAbortTimes is described as: increment when change the max read position or add a abort txn.
In inplementation, we only increment it when change the max read position.

Modifications

Rename changeMaxReadPositionAndAddAbortTimes to changeMaxReadPositionTimes.

Verifying this change

  • Make sure that the change passes the CI checks.

(Please pick either of the following options)

This change is a trivial rework / code cleanup without any test coverage.

Does this pull request potentially affect one of the following parts:

If the box was checked, please highlight the changes

  • Dependencies (add or upgrade a dependency)
  • The public API
  • The schema
  • The default values of configurations
  • The threading model
  • The binary protocol
  • The REST endpoints
  • The admin CLI options
  • The metrics
  • Anything that affects deployment

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

Matching PR in forked repository

PR in forked repository:

Copy link

github-actions bot commented May 6, 2024

@thetumbled Please add the following content to your PR description and select a checkbox:

- [ ] `doc` <!-- Your PR contains doc changes -->
- [ ] `doc-required` <!-- Your PR changes impact docs and you will update later -->
- [ ] `doc-not-needed` <!-- Your PR changes do not impact docs -->
- [ ] `doc-complete` <!-- Docs have been already added -->

@github-actions github-actions bot added doc-not-needed Your PR changes do not impact docs and removed doc-label-missing labels May 6, 2024
@thetumbled
Copy link
Member Author

PTAL, thanks. @lhotari @congbobo184 @liangyepianzhou @poorbarcode

@dao-jun dao-jun added area/broker type/cleanup Code or doc cleanups e.g. remove the outdated documentation or remove the code no longer in use area/transaction ready-to-test labels May 8, 2024
@dao-jun dao-jun added this to the 3.3.0 milestone May 8, 2024
@thetumbled thetumbled changed the title [fix] [broker] rename to changeMaxReadPositionTimes. [fix] [broker] rename to changeMaxReadPositionCount May 8, 2024
Copy link
Member

@lhotari lhotari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@coderzc coderzc modified the milestones: 3.3.0, 3.4.0 May 8, 2024
@thetumbled
Copy link
Member Author

/pulsarbot rerun-failure-checks

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.12%. Comparing base (bbc6224) to head (3e2e3a4).
Report is 240 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #22656      +/-   ##
============================================
- Coverage     73.57%   73.12%   -0.45%     
+ Complexity    32624     2401   -30223     
============================================
  Files          1877     1887      +10     
  Lines        139502   141068    +1566     
  Branches      15299    15482     +183     
============================================
+ Hits         102638   103163     +525     
- Misses        28908    29925    +1017     
- Partials       7956     7980      +24     
Flag Coverage Δ
inttests 27.33% <71.42%> (+2.74%) ⬆️
systests 24.61% <0.00%> (+0.28%) ⬆️
unittests 72.15% <100.00%> (-0.70%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...ransaction/buffer/impl/TopicTransactionBuffer.java 88.16% <100.00%> (+0.41%) ⬆️

... and 337 files with indirect coverage changes

@dao-jun dao-jun merged commit 5ab0512 into apache:master May 8, 2024
49 of 50 checks passed
lhotari pushed a commit that referenced this pull request May 14, 2024
lhotari pushed a commit that referenced this pull request May 14, 2024
nikhil-ctds pushed a commit to datastax/pulsar that referenced this pull request May 15, 2024
(cherry picked from commit 5ab0512)
(cherry picked from commit 1cf6a72)
srinath-ctds pushed a commit to datastax/pulsar that referenced this pull request May 16, 2024
(cherry picked from commit 5ab0512)
(cherry picked from commit 1cf6a72)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants