[fix] [ml] Mark delete stuck due to switching cursor ledger fails #22662
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codelipenghui
approved these changes
May 7, 2024
hangc0276
approved these changes
May 7, 2024
dao-jun
approved these changes
May 7, 2024
|
/pulsarbot rerun-failure-checks |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #22662 +/- ##
============================================
- Coverage 73.57% 72.69% -0.88%
+ Complexity 32624 32546 -78
============================================
Files 1877 1887 +10
Lines 139502 141023 +1521
Branches 15299 15482 +183
============================================
- Hits 102638 102521 -117
- Misses 28908 30639 +1731
+ Partials 7956 7863 -93
Flags with carried forward coverage won't be shown. Click here to find out more.
|
poorbarcode
added
cherry-picked/branch-3.0
cherry-picked/branch-3.2
and removed
release/2.10.7
release/2.11.5
labels
nikhil-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
May 13, 2024
…ache#22662) (cherry picked from commit a7e1fcd) (cherry picked from commit bfd4153)
srinath-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
May 16, 2024
…ache#22662) (cherry picked from commit a7e1fcd) (cherry picked from commit bfd4153)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Background
inProgressMarkDeletePersistPositionis used to trace whether there is an in-progress BK writing, it increases when starting a BK writing, and decreases when the writing is completed.Issue
#20935 forgot to decrease the variable
inProgressMarkDeletePersistPositionwhen writing fails, leading to the cursor ledger switching to stuck, because the cursor assumes there is always an in-progress BK writing.Modifications
Fix the bug.
Documentation
docdoc-requireddoc-not-neededdoc-completeMatching PR in forked repository
PR in forked repository: x